Skip to content

refactor: update schemas and fix some issues #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luxass merged 12 commits into from
Jan 5, 2026
Merged

refactor: update schemas and fix some issues #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1024d83
refactor(schemas): rename schemas and improve validation tests
luxass Jan 5, 2026
b11e692
refactor(schemas): rename Unicode tree schemas and add DeepOmit type
luxass Jan 5, 2026
8adafb3
test(schemas): add comprehensive validation tests for schemas
luxass Jan 5, 2026
e9a7302
chore: upgrade zod to fix issues with duplicate ids
luxass Jan 5, 2026
3224787
chore: perfom renames for unicode file tree
luxass Jan 5, 2026
9da39c0
chore: update apache-autoindex-parse to version 5.0.2
luxass Jan 5, 2026
45e759e
refactor(api): improve statistics handling and type casting
luxass Jan 5, 2026
9598878
feat(shared): add file search and flattening functions
luxass Jan 5, 2026
188d099
refactor(shared): improve type handling in filter functions
luxass Jan 5, 2026
e57f2d3
test(api): enhance file-tree tests with structured data
luxass Jan 5, 2026
dbb50a2
test(client): update base URL handling in version tests
luxass Jan 5, 2026
f1e82e6
refactor(utils): remove unused type `TreeEntry` from exports
luxass Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions apps/api/src/routes/v1_versions/$version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import type { OpenAPIHono } from "@hono/zod-openapi";
import type { UnicodeFileTree } from "@ucdjs/schemas";
import type { HonoEnv } from "../../types";
import { createRoute } from "@hono/zod-openapi";
import { dedent } from "@luxass/utils";
import { UnicodeTreeSchema, UnicodeVersionDetailsSchema } from "@ucdjs/schemas";
import { UnicodeFileTreeNodeSchema, UnicodeFileTreeSchema, UnicodeVersionDetailsSchema } from "@ucdjs/schemas";
import {
hasUCDFolderPath,
resolveUCDVersion,
Expand Down Expand Up @@ -108,7 +109,7 @@ export const GET_VERSION_FILE_TREE_ROUTE = createRoute({
200: {
content: {
"application/json": {
schema: UnicodeTreeSchema,
schema: UnicodeFileTreeSchema,
examples: {
default: {
summary: "File tree for a Unicode version",
Expand Down Expand Up @@ -208,19 +209,32 @@ export function registerGetVersionRoute(router: OpenAPIHono<HonoEnv>) {

// Try to get statistics from bucket if available
const bucket = c.env.UCD_BUCKET;
let statistics = null;
let statistics = {
newBlocks: 0,
newCharacters: 0,
newScripts: 0,
totalBlocks: 0,
totalCharacters: 0,
totalScripts: 0,
};

// This is so bad.... but we have to do it for now.
if (bucket) {
statistics = await calculateStatistics(bucket, version);
const tmp = await calculateStatistics(bucket, version);
if (tmp) {
statistics = tmp;
}
}

return c.json({
...versionInfo,
statistics: statistics ?? undefined,
statistics,
}, 200);
});
}

export function registerVersionFileTreeRoute(router: OpenAPIHono<HonoEnv>) {
router.openAPIRegistry.register("UnicodeFileTreeNode", UnicodeFileTreeNodeSchema);
router.openapi(GET_VERSION_FILE_TREE_ROUTE, async (c) => {
try {
let version = c.req.param("version");
Expand All @@ -243,7 +257,11 @@ export function registerVersionFileTreeRoute(router: OpenAPIHono<HonoEnv>) {
format: "F2",
});

return c.json(result, 200);
// We cast the result to UnicodeFileTree because the traverse function
// returns entries that uses lastModified as `number | undefined`.
// But we can't use the `number | undefined` type in the API schema.
// So we need to return lastModified as `number | null` always.
return c.json(result as UnicodeFileTree, 200);
} catch (error) {
console.error("Error processing directory:", error);
return internalServerError(c, {
Expand Down
Loading
Loading