From 4118246db23c984e51434f1fbd43d927695fb560 Mon Sep 17 00:00:00 2001 From: Florian Weber Date: Fri, 31 Oct 2025 10:48:58 +0100 Subject: [PATCH 1/2] Refactor attribute handling in TwigExtrasExtension --- .../src/Twig/Extension/TwigExtrasExtension.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/uebertool-companion/modules/uebertool_twig/src/Twig/Extension/TwigExtrasExtension.php b/packages/uebertool-companion/modules/uebertool_twig/src/Twig/Extension/TwigExtrasExtension.php index 8e88f0d..7d8f339 100644 --- a/packages/uebertool-companion/modules/uebertool_twig/src/Twig/Extension/TwigExtrasExtension.php +++ b/packages/uebertool-companion/modules/uebertool_twig/src/Twig/Extension/TwigExtrasExtension.php @@ -224,9 +224,13 @@ public function linkAttributes(?array $build): Attribute { /** @var \DOMElement[] $elements */ $element = $xpath->query('//a')->item(0); - $attribute = new Attribute(array_map(function ($item) { - return $item->nodeValue; - }, iterator_to_array($element->attributes->getIterator()))); + $attribute = new Attribute(); + if ($element && $element->hasAttributes()) { + $attribute = new Attribute(array_map(function ($item) { + return $item->nodeValue; + }, iterator_to_array($element->attributes->getIterator()))); + $attribute->removeAttribute('href'); + } $attribute->removeAttribute('href'); return $attribute; } From a09a97410789a2baa4c6c26bebea884e85b303ef Mon Sep 17 00:00:00 2001 From: Florian Weber Date: Tue, 11 Nov 2025 11:10:29 +0100 Subject: [PATCH 2/2] Update TwigExtrasExtension.php --- .../uebertool_twig/src/Twig/Extension/TwigExtrasExtension.php | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/uebertool-companion/modules/uebertool_twig/src/Twig/Extension/TwigExtrasExtension.php b/packages/uebertool-companion/modules/uebertool_twig/src/Twig/Extension/TwigExtrasExtension.php index 7d8f339..8c47b3f 100644 --- a/packages/uebertool-companion/modules/uebertool_twig/src/Twig/Extension/TwigExtrasExtension.php +++ b/packages/uebertool-companion/modules/uebertool_twig/src/Twig/Extension/TwigExtrasExtension.php @@ -231,7 +231,6 @@ public function linkAttributes(?array $build): Attribute { }, iterator_to_array($element->attributes->getIterator()))); $attribute->removeAttribute('href'); } - $attribute->removeAttribute('href'); return $attribute; }