From 3ebf78df758c1b284edbf57f6a5facd4b1e08ae7 Mon Sep 17 00:00:00 2001 From: Dedmen Miller Date: Sun, 6 Jul 2025 04:06:33 +0200 Subject: [PATCH 1/3] Fixed missing nullptr check in OverlayManager::FireMouseEvent --- src/common/OverlayManager.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/common/OverlayManager.cpp b/src/common/OverlayManager.cpp index 2dcc32d..9848ebb 100644 --- a/src/common/OverlayManager.cpp +++ b/src/common/OverlayManager.cpp @@ -82,7 +82,8 @@ void OverlayManager::FireMouseEvent(const ultralight::MouseEvent& evt) { rel_evt.x -= (int)std::round(hovered_overlay_->x() / window_scale_); rel_evt.y -= (int)std::round(hovered_overlay_->y() / window_scale_); - focused_overlay_->view()->FireMouseEvent(rel_evt); + if (focused_overlay_) + focused_overlay_->view()->FireMouseEvent(rel_evt); if (evt.type == ultralight::MouseEvent::kType_MouseUp && evt.button == MouseEvent::kButton_Left) is_dragging_ = false; From 9adb67c44547ec3886b45ae9746803a3c20a0e1a Mon Sep 17 00:00:00 2001 From: Dedmen Miller Date: Sun, 6 Jul 2025 04:08:29 +0200 Subject: [PATCH 2/3] Second missed check --- src/common/OverlayManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/OverlayManager.cpp b/src/common/OverlayManager.cpp index 9848ebb..62ed2e4 100644 --- a/src/common/OverlayManager.cpp +++ b/src/common/OverlayManager.cpp @@ -102,7 +102,7 @@ void OverlayManager::FireMouseEvent(const ultralight::MouseEvent& evt) { focused_overlay_ = hovered_overlay_; - if (window_focused_) + if (window_focused_ && focused_overlay_) focused_overlay_->view()->Focus(); is_dragging_ = true; } From 5d5adb515838a7687a039978d249a399241c7e32 Mon Sep 17 00:00:00 2001 From: Dedmen Miller Date: Sun, 6 Jul 2025 04:10:09 +0200 Subject: [PATCH 3/3] Update OverlayManager.cpp --- src/common/OverlayManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/OverlayManager.cpp b/src/common/OverlayManager.cpp index 62ed2e4..9848ebb 100644 --- a/src/common/OverlayManager.cpp +++ b/src/common/OverlayManager.cpp @@ -102,7 +102,7 @@ void OverlayManager::FireMouseEvent(const ultralight::MouseEvent& evt) { focused_overlay_ = hovered_overlay_; - if (window_focused_ && focused_overlay_) + if (window_focused_) focused_overlay_->view()->Focus(); is_dragging_ = true; }