Skip to content

implementgeneric API error handling #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vyshanv-mv wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

implementgeneric API error handling #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pos/src/lib/customer-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { DOCTYPES } from '../data/doctypes';
import { db, call } from './frappe-sdk';
import { handleApiError } from './error-handler';

export interface Customer {
name: string;
Expand Down Expand Up @@ -103,6 +104,7 @@ export async function searchCustomers(search: string, limit = 5) {
return res.message || [];
} catch (error) {
console.error('Customer search error:', error);
throw error;
const errorMessage = handleApiError(error);
throw new Error(errorMessage);
}
}
27 changes: 27 additions & 0 deletions pos/src/lib/error-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
export interface ApiError {
message?: string;
exc_type?: string;
_server_messages?: string;
}

export const handleApiError = (error: any): string => {
console.error("API Error:", error);
if (error?.response?.data?._server_messages) {
try {
const serverMessages = JSON.parse(error.response.data._server_messages);
const parsedMessage = JSON.parse(serverMessages[0]);
return parsedMessage.message || "Something went wrong";
} catch {
return "Server error occurred";
}
}

if (error?.response?.data?.message) {
return error.response.data.message;
}

if (error?.message) {
return error.message;
}
return "Unexpected error occurred. Please try again.";
};
10 changes: 5 additions & 5 deletions pos/src/lib/payment-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { call } from './frappe-sdk';
import { handleApiError } from './error-handler';

interface PaymentMode {
mode_of_payment: string;
Expand All @@ -19,14 +20,13 @@ export const getPaymentModes = async (): Promise<string[]> => {
try {
const response = await call.get<PaymentModeResponse>("ury.ury_pos.api.getModeOfPayment");

const paymentModes = response.message.map((mode:PaymentMode) => mode.mode_of_payment);

// Cache in session storage
const paymentModes = response.message.map((mode: PaymentMode) => mode.mode_of_payment);
sessionStorage.setItem('payment_modes', JSON.stringify(paymentModes));

return paymentModes;
} catch (error) {
console.error('Failed to fetch payment modes:', error);
throw error;
const errorMessage = handleApiError(error);
throw new Error(errorMessage);
}
};
Loading