Skip to content

Optimize indexed kv. #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcushanses merged 1 commit into from
Feb 13, 2025
Merged

Optimize indexed kv. #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions KeyValueStore/Indexed/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,11 @@ export class Indexed<V, I extends string, M = any> implements KeyValueStore<V, M
set(key: string, value: V, options?: { retention?: TimeSpan; meta?: M }): Promise<void>
async set(key: string, value?: V, options?: { retention?: TimeSpan; meta?: M }): Promise<void> {
const old = (await this.data.get(key))?.value
if (old) {
await this.data.set(key)
await Promise.all((Object.values(this.indexes) as Index<V>[]).map(index => index.set(old)))
}
if (value) {
if (value)
await this.data.set(key, value, options)
await Promise.all((Object.values(this.indexes) as Index<V>[]).map(index => index.set(value, key, options)))
}
else if (old)
await this.data.set(key)
await Promise.all(Object.values<Index<V>>(this.indexes).map(index => index.set(value, old, key, options)))
}
async get(key: string, index?: I): Promise<{ value: V; meta?: M | undefined } | undefined> {
let result: { value: V; meta?: M | undefined } | undefined
Expand Down Expand Up @@ -57,14 +54,18 @@ export class Indexed<V, I extends string, M = any> implements KeyValueStore<V, M

class Index<V> {
constructor(private index: (value: V) => string | undefined, private backend: KeyValueStore<string>) {}
set(value: V): Promise<void>
set(value: V, key: string, options?: { retention?: TimeSpan | undefined }): Promise<void>
async set(value: V, key?: string, options?: { retention?: TimeSpan | undefined }): Promise<void> {
const index = this.index(value)
if (key && index)
async set(
value: V | undefined,
oldValue: V | undefined,
key: string,
options?: { retention?: TimeSpan | undefined }
): Promise<void> {
const index = value && this.index(value)
const oldIndex = oldValue && this.index(oldValue)
if (oldIndex && (!index || index !== oldIndex))
await this.backend.set(oldIndex)
if (index)
await this.backend.set(index, key, options)
else if (index)
await this.backend.set(index)
}
async get(key: string): Promise<string | undefined> {
return (await this.backend.get(key))?.value
Expand Down