fix: correct type annotations for ids parameter and test assertions

- Change ids parameter type from list[int] to list[str] in dicttoxml function
- Update convert_dict and convert_dict_parallel to accept list[str] | None
- Fix test to use string list instead of int list for ids
- Add None check in test_parallel.py before type narrowing result_bytes

Amp-Thread-ID: https://ampcode.com/threads/T-ab40799c-7282-451b-bdf6-4a74c73a62b7
Co-authored-by: Amp <amp@ampcode.com>

Author: vinitkumar

json2xml/dicttoxml.py

@@ -331,7 +331,7 @@ def list2xml_str(
 
 def convert_dict(
     obj: dict[str, Any],
-    ids: list[str],
+    ids: list[str] | None,
     parent: str,
     attr_type: bool,
     item_func: Callable[[str], str],
@@ -557,7 +557,7 @@ def dicttoxml(
     obj: ELEMENT,
     root: bool = True,
     custom_root: str = "root",
-    ids: list[int] | None = None,
+    ids: list[str] | None = None,
     attr_type: bool = True,
     item_wrap: bool = True,
     item_func: Callable[[str], str] = default_item_func,

json2xml/parallel.py

@@ -177,7 +177,7 @@ def _convert_dict_item(
 
 def convert_dict_parallel(
     obj: dict[str, Any],
-    ids: list[str],
+    ids: list[str] | None,
     parent: str,
     attr_type: bool,
     item_func: Callable[[str], str],

tests/test_dict2xml.py

@@ -763,7 +763,7 @@ def test_convert_with_float(self) -> None:
     def test_dicttoxml_with_ids(self) -> None:
         """Test dicttoxml with IDs parameter."""
         data = {"key": "value"}
-        result = dicttoxml.dicttoxml(data, ids=[1, 2, 3], attr_type=False)
+        result = dicttoxml.dicttoxml(data, ids=["1", "2", "3"], attr_type=False)
         assert b'<key id="root_' in result
         assert b'">value</key>' in result
 

tests/test_parallel.py

@@ -159,7 +159,8 @@ def test_json2xml_parallel_complex(self) -> None:
         result_serial = converter_serial.to_xml()
 
         assert result_parallel == result_serial
-        result_bytes = result_parallel.encode() if isinstance(result_parallel, str) else result_parallel
+        assert result_parallel is not None
+        result_bytes: bytes = result_parallel.encode() if isinstance(result_parallel, str) else result_parallel
         assert b"<users" in result_bytes
         assert b"<total" in result_bytes