git-pair should work in any directory when used globally

[nertzy]

I always put global: true in my .pairs file, and I usually either keep it in my home directory, or symlink one from a project I most often work on to the home directory.

But even when I have ~/.pairs with global mode on, I get this...

$ git pair gh
fatal: Not a git repository (or any of the parent directories): .git

We should just set the global git user.

[tjarratt]

I'm not sure how this would work realistically. To the best of my knowledge, git does not invoke any plugins unless you are currently in a git repo.

@nertzy have you had any clever ideas for how to resolve this in the past two years? Could we close this issue?

[nertzy]

I gave it a shot but I need to spend a little longer on it to get it right.

The core issue is that we check if we are in a git directory, and if not, we exit 1
(see https://github.com/pivotal/git_scripts/blob/81f510dd32cd3de8a1b720d5067c7d427289755e/lib/pivotal_git_scripts/git_pair.rb#L23)

But if we're using --global, it would be better to detect that we are not in a git directory and skip any local behavior instead.

[tjarratt]

Oh, I'm glad to learn that I'm totally wrong. Would be interested in getting that PR merged, this is useful behavior indeed!

[igbanam]

Did this gain any traction?