From 3c1b4e5e92ba241115c4b8559ecd80fee81a982b Mon Sep 17 00:00:00 2001 From: Hans Dijkema Date: Fri, 17 Oct 2025 23:47:57 +0200 Subject: [PATCH 1/3] Fixed problem with array allocation for executables array. MAX_BROWSER_FILES needed to be 5. Also initialized all array entries to NULL before assigning executable names. Signed-off-by: Hans Dijkema --- src/webui.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/webui.c b/src/webui.c index d7e1c612a..0b993432c 100644 --- a/src/webui.c +++ b/src/webui.c @@ -6077,9 +6077,14 @@ static bool _webui_custom_browser_exist(_webui_window_t* win, size_t browser) { } } #else - #define MAX_BROWSER_FILES (2) + #define MAX_BROWSER_FILES (5) char* executable = NULL; char* executables[MAX_BROWSER_FILES] = {0}; + { + int i; + for(i = 0; i < MAX_BROWSER_FILES; i++) + executables[i] = NULL; + } if (browser == Chrome) { executables[0] = "google-chrome"; executables[1] = "google-chrome-stable"; @@ -6090,7 +6095,6 @@ static bool _webui_custom_browser_exist(_webui_window_t* win, size_t browser) { } else if (browser == Epic) { executables[0] = "epic"; - executables[1] = NULL; } else if (browser == Vivaldi) { executables[0] = "vivaldi"; @@ -6101,7 +6105,6 @@ static bool _webui_custom_browser_exist(_webui_window_t* win, size_t browser) { executables[1] = "brave-browser-stable"; executables[2] = "brave-browser-nightly"; executables[3] = "brave-browser-beta"; - executables[4] = NULL; } else if (browser == Firefox) { executables[0] = "firefox"; From 9d83d0fc2c4bc2cf7802c4c2e35a2ca4995b0159 Mon Sep 17 00:00:00 2001 From: Hans Dijkema Date: Fri, 17 Oct 2025 23:48:31 +0200 Subject: [PATCH 2/3] Removed some NULL assignments that are not needed anymore. Signed-off-by: Hans Dijkema --- src/webui.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/webui.c b/src/webui.c index 0b993432c..b52418f57 100644 --- a/src/webui.c +++ b/src/webui.c @@ -6108,11 +6108,9 @@ static bool _webui_custom_browser_exist(_webui_window_t* win, size_t browser) { } else if (browser == Firefox) { executables[0] = "firefox"; - executables[1] = NULL; } else if (browser == Yandex) { executables[0] = "yandex-browser"; - executables[1] = NULL; } else if (browser == Chromium) { executables[0] = "chromium-browser"; From 98c1dff2efed17d9ef95aa3fb2a83f21532f5d10 Mon Sep 17 00:00:00 2001 From: Showns <116365846+AlbertShown@users.noreply.github.com> Date: Mon, 20 Oct 2025 15:54:14 -0400 Subject: [PATCH 3/3] Simplify initialization of executables array Removed unnecessary initialization loop for executables array. --- src/webui.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/webui.c b/src/webui.c index b52418f57..a8fe808a8 100644 --- a/src/webui.c +++ b/src/webui.c @@ -6080,11 +6080,6 @@ static bool _webui_custom_browser_exist(_webui_window_t* win, size_t browser) { #define MAX_BROWSER_FILES (5) char* executable = NULL; char* executables[MAX_BROWSER_FILES] = {0}; - { - int i; - for(i = 0; i < MAX_BROWSER_FILES; i++) - executables[i] = NULL; - } if (browser == Chrome) { executables[0] = "google-chrome"; executables[1] = "google-chrome-stable";