Refactor tests

[nsorros]

Problems

• tests contain a lot of duplicate code that can be refactored for example creating test data on the fly and training models needed to test certain functions
• do not make full use of pytest fixtures everywhere. for example for creating temp folders

[aCampello]

In addition to this, it seems that we are testing on tox AND pytest:

        $(VIRTUALENV)/bin/pytest --disable-warnings -v --cov=grants_tagger
        $(VIRTUALENV)/bin/tox

Isn't the second one redundant?

[nsorros]

i think that pytest is testing with the development environment installed while tox with the library installed. these are two different environments.

[aCampello]

That a makes sense - but the tests are the same - in principle we could drop one?

[nsorros]

That a makes sense - but the tests are the same - in principle we could drop one?

definitely but its like running the same tests on different python versions