Remove preferHitOverExpertise option, auto-detect caster specs

- Removed preferHitOverExpertise boolean parameter from ReforgeOptimizer
- Replaced with automatic caster spec detection
- Casters (Mage, Warlock, Priest, Balance/Resto Druid, Ele/Resto Shaman, Holy Paladin, Mistweaver Monk) now automatically prefer Hit over Expertise
- Removed preferHitOverExpertise: true from all mage spec UIs

Author: Saji-Saji

ui/core/components/suggest_reforges_action.tsx

@@ -108,9 +108,6 @@ export type ReforgeOptimizerOptions = {
 	// Sets the default stat to be the highest for relative stat cap calculations
 	// Defaults to Any
 	defaultRelativeStatCap?: Stat | null;
-	// For casters: prefer Hit Rating over Expertise Rating
-	// This filters out Expertise reforges when Hit reforges are available for the same item
-	preferHitOverExpertise?: boolean;
 };
 
 // Used to force a particular proc from trinkets like Matrix Restabilizer and Apparatus of Khaz'goroth.
@@ -248,7 +245,6 @@ export class ReforgeOptimizer {
 	protected statTooltips: StatTooltipContent = {};
 	protected additionalSoftCapTooltipInformation: StatTooltipContent = {};
 	protected statSelectionPresets: ReforgeOptimizerOptions['statSelectionPresets'];
-	protected preferHitOverExpertise: boolean;
 	protected includeGems = false;
 	protected includeEOTBPGemSocket = false;
 	protected freezeItemSlots = false;
@@ -295,7 +291,6 @@ export class ReforgeOptimizer {
 		this._statCaps = this.defaults.statCaps || new Stats();
 		this.enableBreakpointLimits = !!options?.enableBreakpointLimits;
 		this.relativeStatCapStat = options?.defaultRelativeStatCap ?? -1;
-		this.preferHitOverExpertise = options?.preferHitOverExpertise ?? false;
 
 		// Pre-warm the worker pool
 		getReforgeWorkerPool().warmUp();
@@ -1364,11 +1359,21 @@ export class ReforgeOptimizer {
 
 				// For casters: prefer Hit over Expertise
 				// If the item doesn't have Hit or Expertise natively, remove Expertise as a reforge option
-				if (this.preferHitOverExpertise && reforgeData.toStat === Stat.StatExpertiseRating) {
-					const itemStats = scaledItem.calcStats(slot);
+				const isCaster = this.playerClass === Class.ClassMage ||
+					this.playerClass === Class.ClassWarlock ||
+					this.playerClass === Class.ClassPriest ||
+					this.player.getSpec() === Spec.SpecBalanceDruid ||
+					this.player.getSpec() === Spec.SpecRestorationDruid ||
+					this.player.getSpec() === Spec.SpecElementalShaman ||
+					this.player.getSpec() === Spec.SpecRestorationShaman ||
+					this.player.getSpec() === Spec.SpecHolyPaladin ||
+					this.player.getSpec() === Spec.SpecMistweaverMonk;
+
+				if (isCaster && reforgeData.toStat === Stat.StatExpertiseRating) {
+					const itemStats = scaledItem.calcStats();
 					const hasNativeHit = itemStats.getStat(Stat.StatHitRating) > 0;
 					const hasNativeExpertise = itemStats.getStat(Stat.StatExpertiseRating) > 0;
-					
+
 					// If item has neither Hit nor Expertise natively, don't allow reforging to Expertise
 					if (!hasNativeHit && !hasNativeExpertise) {
 						return false;

ui/mage/arcane/sim.tsx

@@ -172,7 +172,6 @@ export class ArcaneMageSimUI extends IndividualSimUI<Spec.SpecArcaneMage> {
 		this.reforger = new ReforgeOptimizer(this, {
 			statSelectionPresets: statSelectionPresets,
 			enableBreakpointLimits: true,
-			preferHitOverExpertise: true,
 			getEPDefaults: player => {
 				const avgIlvl = player.getGear().getAverageItemLevel(false);
 				if (avgIlvl >= 525) {

ui/mage/fire/sim.tsx

@@ -309,7 +309,6 @@ export class FireMageSimUI extends IndividualSimUI<Spec.SpecFireMage> {
 		this.reforger = new ReforgeOptimizer(this, {
 			statSelectionPresets: statSelectionPresets,
 			enableBreakpointLimits: true,
-			preferHitOverExpertise: true,
 			// updateSoftCaps: softCaps => {
 			// 	const raidBuffs = player.getRaid()?.getBuffs();
 			// 	const hasBL = !!raidBuffs?.bloodlust;

ui/mage/frost/sim.ts

@@ -188,7 +188,6 @@ export class FrostMageSimUI extends IndividualSimUI<Spec.SpecFrostMage> {
 		this.reforger = new ReforgeOptimizer(this, {
 			statSelectionPresets: [MAGE_BREAKPOINTS],
 			enableBreakpointLimits: true,
-			preferHitOverExpertise: true,
 			getEPDefaults: player => {
 				const avgIlvl = player.getGear().getAverageItemLevel(false);
 				if (avgIlvl >= 517) {