Skip to content

Once hidden, next button doesn't show up #153

@mikocot

Description

@mikocot

When mixing steps between those that require user interaction and those that only highlight items it's useful to turn on and of the next button for every step independently. As much as this works for the previous button, it doesn't for the 'next'.

The only way to bring back the next button after it was hidden once is to use the event_type: next. It's not a big issue, but on the other hand it prevents us from also accepting 'click' as an alternative condition to move to the next step, which in some cases is still convenient to have.

This behavior is rather clear from the code:

//here, unless specifically set to true 'next' is hidden, but if it was hidden already, regardless the value, there is no logic to show it
          if (step_data.showNext !== true) {                    
            $body.enjoyhint("hide_next");
          }
          
          $body.enjoyhint("hide_prev");

          if(current_step !== 0) {
            $body.enjoyhint("show_prev");
          }

          if (step_data.showPrev == false) {
            $body.enjoyhint("hide_prev");
        }

          if (step_data.showSkip == false) {
            $body.enjoyhint("hide_skip");
          } else {
            $body.enjoyhint("show_skip");
          }

I believe that forcing showNext: true should still allow to show the next button regardless the event type.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions