From 976652d3d6d00ffd4b271bc6b41ba4525561341d Mon Sep 17 00:00:00 2001 From: "lawrence.turcotte" Date: Sat, 11 Feb 2023 19:09:52 -0500 Subject: [PATCH 1/2] fix: plugin startup problem due to empty persisted data --- src/lib.js | 3 +++ src/popup.js | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/lib.js b/src/lib.js index 536bf99..1096c82 100644 --- a/src/lib.js +++ b/src/lib.js @@ -59,6 +59,9 @@ function keywordsToStr(kws, settings){ // and the last one kws.length && (str += kws[kws.length-1].kwStr); }else{ + if (!Array.isArray(kws)) { + return str + } str = kws.map(kw=>kw.kwStr).join(settings.delim); // append deliminator if there are words str += str ? settings.delim : ""; diff --git a/src/popup.js b/src/popup.js index ab434f4..341f16a 100644 --- a/src/popup.js +++ b/src/popup.js @@ -87,6 +87,9 @@ window.addEventListener('load', function() { function build_keywords_list(inputKws){ + if (!Array.isArray(inputKws)) { + return + } var html = inputKws.map(kw=>`${kw.kwStr}`).join(""); $('#kw-list>.keywords').remove(); $(html).appendTo($('#kw-list')); From 40109d70456b6d6d4038d41fae167a9a9533c0c4 Mon Sep 17 00:00:00 2001 From: "lawrence.turcotte" Date: Wed, 22 Feb 2023 11:14:42 -0500 Subject: [PATCH 2/2] fix: KeywordsMinus from non array argument --- src/lib.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lib.js b/src/lib.js index 1096c82..3368f71 100644 --- a/src/lib.js +++ b/src/lib.js @@ -78,6 +78,8 @@ function KeywordsMinus(kwListA, kwListB){ return false; } // console.log(kwListA.map(x=>KwListContain(kwListB, x))); - return kwListA.filter(x=>!KwListContain(kwListB, x)); - + if (Array.isArray(kwListA)) { + return kwListA.filter(x=>!KwListContain(kwListB, x)); + } + return [] //empty array }