Skip to content

Added static typing#85

Open
thekingofspace wants to merge 4 commits into1ForeverHD:mainfrom
thekingofspace:main
Open

Added static typing#85
thekingofspace wants to merge 4 commits into1ForeverHD:mainfrom
thekingofspace:main

Conversation

@thekingofspace
Copy link

Makes it easier to work with in roblox studio and prevents the type logger from spewing hundreds of errors.

Still need to add groups to it, I need to read how they work, will create another PR once that is done.

@1ForeverHD
Copy link
Owner

Thanks for adding types @thekingofspace 🙏 excited to review this when we begin the ZonePlus updates

@thekingofspace
Copy link
Author

Thanks for adding types @thekingofspace 🙏 excited to review this when we begin the ZonePlus updates

A issue I saw as well is inside init you tied your zone methods into the module creator... I mean this works but why would I wanna spawn a new zone from a existing zone? I was gonna correct it but didn't know if you had a reason for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments