Draft: Change the representation of unit types#98
Draft
LuminaSapphira wants to merge 1 commit intomainfrom
Draft
Draft: Change the representation of unit types#98LuminaSapphira wants to merge 1 commit intomainfrom
LuminaSapphira wants to merge 1 commit intomainfrom
Conversation
…to-null"" This reverts commit 08769e5.
LuminaSapphira
force-pushed
the
fix/unit-type-null
branch
from
43f2775 to
dbcb456
Compare
Contributor
|
Per #96, it seems like the relevant types should be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was previously fixed though its merge highlighted several issues that have yet to be resolved. See discussion at the following locations.
#43
#82
#96
This is the new PR to fix this which helpfully already includes the necessary 'revert revert' commit.