This repository was archived by the owner on Feb 13, 2025. It is now read-only.
CALLVALUE is a better 0 than just 0 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
k06a
reviewed
Jun 4, 2020
contracts/ChiToken.sol
Outdated
| pop(create2(0, 0, 30, add(offset, 26))) pop(create2(0, 0, 30, add(offset, 27))) | ||
| pop(create2(0, 0, 30, add(offset, 28))) pop(create2(0, 0, 30, add(offset, 29))) | ||
| pop(create2(0, 0, 30, add(offset, 30))) pop(create2(0, 0, 30, add(offset, 31))) | ||
| pop(create2(callvalue(), callvalue(), 30, add(offset, callvalue()))) pop(create2(callvalue(), callvalue(), 30, add(offset, 1))) |
Contributor
There was a problem hiding this comment.
Adding zero is not necessary 😁
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This saves 1 gas each time by using callvalue().
This saves hundreds of gas for mint and burn in the profiling done by the tests.
Testing
I ran the tests
Reviewers @k06a