Refactoring follow player/NPC variables and NPC magic numbers#659
Merged
Dark98 merged 7 commits into2006-Scape:masterfrom Dec 6, 2024
Merged
Refactoring follow player/NPC variables and NPC magic numbers#659Dark98 merged 7 commits into2006-Scape:masterfrom
Dark98 merged 7 commits into2006-Scape:masterfrom
Conversation
GWD was added in 2007, not 2006, so there's absolutely no reason why this code should exist in the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one PR makes this code base so much more workable.
For example, I discovered that there was a bunch of GWD code in here, despite the fact that GWD wasn't added until 2007 not 2006.
Once this gets merged first I'll have to fix the merge conflicts in #658 after.