Fixed exception copying while catching #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode 10.3 fails to build due to exception being catched by value:
/Applications/Xcode.app/Contents/Developer/usr/bin/make dirs libnima.a headers
clang++ -Wall -Werror -g -std=c++11 -I./ -INima-Math-Cpp/Build/include -c Source/Actor.cpp -o Build/obj/Source/Actor.o
Source/Actor.cpp:280:9: error: local variable 'ex' will be copied despite being
thrown by name [-Werror,-Wreturn-std-move]
throw ex;
^~
Source/Actor.cpp:280:9: note: call 'std::move' explicitly to avoid copying
throw ex;
^~
std::move(ex)
1 error generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 10.3 fails to build due to exception being catched by value: