fix: FTBFS with recent gcc versions #445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling, gcc throws an error about missing header for std::find()
There was a problem hiding this comment.
Pull request overview
This PR fixes a compilation failure (FTBFS - Fails To Build From Source) with recent GCC versions by adding the missing <algorithm> header required for std::find(). Recent GCC versions have stricter requirements for explicit header inclusion and no longer transitively include <algorithm> through other headers.
- Adds
#include <algorithm>to NMR_ResourceDependencySorter.cpp to fix compilation error
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
We already added the include on the develop branch. We will do a release very soon (and merge develop into master). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling, gcc throws an error about missing header for std::find()