Allowing the client to let beanmapper map null collections to null co…#127
Open
RobertAlblas wants to merge 1 commit into42BV:masterfrom
Open
Allowing the client to let beanmapper map null collections to null co…#127RobertAlblas wants to merge 1 commit into42BV:masterfrom
RobertAlblas wants to merge 1 commit into42BV:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
===========================================
- Coverage 93.78% 93.6% -0.19%
- Complexity 849 853 +4
===========================================
Files 87 87
Lines 1785 1797 +12
Branches 174 174
===========================================
+ Hits 1674 1682 +8
- Misses 67 71 +4
Partials 44 44
Continue to review full report at Codecov.
|
arjanvlek
reviewed
May 27, 2019
| @Test | ||
| public void nullListToNullList() { | ||
| BeanMapper beanMapper = new BeanMapperBuilder() | ||
| .setUseCollectionNullValue(false) |
Contributor
There was a problem hiding this comment.
als useCollectionNullValue true is moet volgens mij de value null zijn. Dus als het false is juist niet.
Volgens mij werkt het nu precies verkeerd om...
Author
There was a problem hiding this comment.
Default gebruikt useNullValue true en worden null waarden daarom niet genegeerd. Ik neem aan dat dit op dezelfde manier werkt, klopt dat of denk ik verkeerd?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…llections
Currently, beanmapper always maps null collections to empty collections. Setting useCollectionNullValues to false will map null collections to null collections.