Skip to content

Conversation

@marios-zindilis
Copy link
Contributor

@marios-zindilis marios-zindilis commented May 15, 2025

Added a note in README.rst for how to get the categories out of the list of WikiLinks. This is what it looks like when rendered by Sphinx:

sphinx-docs-screenshot-2

Closes #142

@marios-zindilis marios-zindilis changed the title Added documentation for filtering categories from WikiLinks - Closes #142 Added documentation for filtering categories from WikiLinks May 15, 2025
README.rst Outdated
wl
for wl
in parsed.wikilinks
if wl.title.partition(':')[0].strip() == "Category"
Copy link
Owner

@5j9 5j9 May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions: 1. Add a .lower() here since the namespace is case-insensitive, and some Wikipedians tend to use the lowercase form, i.e., [[category:x]]. 2. It might also be helpful to include the κατηγορία example you provided in issue #142—perhaps by replacing == "Category" with in ('category', 'κατηγορία').

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b78a7b0) to head (de93a72).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         2268      2268           
=========================================
  Hits          2268      2268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@5j9 5j9 merged commit 6ccd6eb into 5j9:main May 15, 2025
17 checks passed
@5j9
Copy link
Owner

5j9 commented May 15, 2025

Perfect! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] Parse categories

2 participants