Fixes an issue with processing backups for database names with periods in their name.#13
Open
pocketarc wants to merge 1 commit into7compass:masterfrom
Open
Fixes an issue with processing backups for database names with periods in their name.#13pocketarc wants to merge 1 commit into7compass:masterfrom
pocketarc wants to merge 1 commit into7compass:masterfrom
Conversation
…s OCin their name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have databases with periods (
.) in the name, and while that's fully supported by MySQL, it chokes up s3-mysql-backup. I just changed the code to look for the date starting from the end (which is always known because of how thefilenamevariable is created).That solved the problem for me and won't cause problems for anyone else.
Just submitting a PR in the hope that it might be of help. 😄