Skip to content

Fix issues in CI pipeline + Implement multi staged build in to two separated Images #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shakyapeiris wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Fix issues in CI pipeline + Implement multi staged build in to two separated Images #55

shakyapeiris wants to merge 19 commits into from

Conversation

@shakyapeiris
Copy link

@shakyapeiris shakyapeiris commented Oct 16, 2021 •
edited
Loading

I have made some changes and the purpose of this pull request is to discuss about the changes I made up to now(I'm planning to do more improvements as mentioned below).

Implemented:

  • Add test step to GitHub actions
  • Fixed issues with unit tests in the server/api (with jest and mongodb-memory-server)
  • Separate front-end and back-end in to two Docker images (client image didn't built successfully)
  • Implement multi-staged build in Images/Dockerfiles
  • Update docker-compose.yml according to implemented changes in Images/Dockerfiles.
  • Add Dockerfile and .dockerignore files to each respective .dockerignore files.

Future:

  • Write all the tests for api
  • Fix issues with the client image
  • Fix issues with dependencies
  • Add docker image build step to the GitHub action

Thank You
Shakya Peiris

@shakyapeiris
write seperate Dockerfiles for server and client
86f9573
@shakyapeiris
update docker compose according to changed images
a97d6b2
@shakyapeiris
delete previously added Dockerfile and .dockerignore file
9fb7a51
@shakyapeiris
add tests and build steps to github workflows
36b6eae
@shakyapeiris
create a helper for db connection
2f5cc93
@shakyapeiris
change filename since using jest
17305d3
@shakyapeiris
update dependencies
6756dfb
@shakyapeiris
implement reusable db module
da0cc14
@shakyapeiris
set the timeout of test script to 2min
907c62d
@shakyapeiris
install mongodb-memory-server and jest
8a45aa1
@shakyapeiris
remove NODE_ENV and ran a successful multistaged image build
a0f76a3
@shakyapeiris
change paths to absolute paths
4b168aa
@shakyapeiris
set to connect main db when NODE_ENV != test
ce73dbf
@shakyapeiris
seperate mock DB connection and main DB connection to seperate functi…
f7f91f1 
…ons and implement database initialization for tests in mock DB connect function
@shakyapeiris
write tests to test players in descending order and teams in descendi…
77d4dca 
…ng order
@shakyapeiris
setup test script with detect open handles and force exit
47804dd
@shakyapeiris
change forwaded port of server to 3003
0738b02
@shakyapeiris
build failed for the client Dockerfile during docker-compose up
7872fe0
@shakyapeiris
Change mongodb url to an environment variable
f3cfc33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shakyapeiris