Clean up repro CI test outputs #176
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeGat
reviewed
Jul 31, 2025
…uccessfully - Delete outputs when test status is not error (which will indiciate whether the model exited without errors) - Add optional input for config-hash to allow grouping commits to a branch (to make it easier to compare checksums on intermediate commits and eventually delete all commits associated with a branch) - Update config-comment-test.yml and test-repro.yml
This might also make issues more clear for scheduled checks on branches that get new commits that fix reproducibility as the comments will point to the older commit
…impler and updated generate checksums
…generate checksums test output
jo-basevi
force-pushed
the
175-clean-up-test-outputs
branch
from
14affd6 to
cfa50f9
Compare
CodeGat
approved these changes
Nov 12, 2025
Member
CodeGat
left a comment
CodeGat
left a comment
There was a problem hiding this comment.
Forgot about this one - thanks for addressing the comment I had
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
test-repro.yml-config-hash. This is so all experiment directories will be set as${{ vars.EXPERIMENTS_LOCATION }}/${{ github.event.repository.name }}/${{ inputs.config-ref }}/${{ inputs.config-hash }}whereconfig-refis the branch or tag name andconfig-hashis the SHA commit hash. This is to make it easier to group commits to a particular branch in a PR (when eventually we set up automation to delete them when PR is closed) and also keep checksums on intermediate commitschecksum.Contributes to #175 - this PR currently does not remove anything when config PRs are closed.
TODO: