Skip to content

Comments

updated gitops from staging#38

Open
matthewpeterkort wants to merge 2 commits intoohsu-trainingfrom
updated_gitops
Open

updated gitops from staging#38
matthewpeterkort wants to merge 2 commits intoohsu-trainingfrom
updated_gitops

Conversation

@matthewpeterkort
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@bwalsh bwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See kyles comments on this slide

https://docs.google.com/presentation/d/1YcSooItJCLbTeUsz4cfCiryzGP6xdaJYGYkc4OJRef0/edit#slide=id.p

image

One clarification here:

This leads to a generic Gen3 site that describes the architecture. Need ACED specific docs

There is a bit of a catch 22 here. We don't have a ACED doc site. For now, have it point to https://www.cancerresearchuk.org/funding-for-researchers/research-opportunities-in-early-detection-and-diagnosis/international-alliance-for-cancer-early-detection

"heading": "Open Access Data Commons",
"text": "The Open Access Data Commons supports the management, analysis and sharing of data for the research community with the aim of accelerating discovery and development of diagnostics, treatment and prevention of diseases.",
"link": "/submission"
"text": "The Open Access Data Commons supports the management, analysis and sharing of data for the research community with the aim of accelerating discovery and development of diagnostics, treatment and prevention of diseases."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kellrott you had some input for this text. I believe it was:


We are uniting world leading researchers to tackle the biggest challenges in early detection, an important area of unmet clinical need. Scientists in the Alliance are working together at the forefront of technological innovation to translate research into realistic ways to improve cancer diagnosis, which can be implemented into health systems and meaningfully benefit people with cancer.```

from https://www.cancerresearchuk.org/funding-for-researchers/research-opportunities-in-early-detection-and-diagnosis/international-alliance-for-cancer-early-detection


Copy link
Collaborator Author

@matthewpeterkort matthewpeterkort Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitops Updated. In the "login" section of the gitops there is a place to put contact,email,and image information and has not yet been updated

I copy pasted the sentence from the home screen to the login since stock gen3 did the same but this should be further considered

NOTE: I do not think the footer can be removed in gitops. This could be done in a local build of windmill.

Also, the "Login" button above the navigation bar in the top right corner when you're logged out doesn't link to anything.

The current front page and login screens:

Screen Shot 2023-02-13 at 9 15 55 AM

Screen Shot 2023-02-13 at 9 17 45 AM

Copy link
Collaborator

@bwalsh bwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants