Recursive evaluation #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglw0521
force-pushed
the
Recursion_evaluation
branch
from
2f6f147 to
25ad3d3
Compare
Member
|
Please rebase this first onto main and then onto #17. this has diverged too far to merge. In the future it would be useful to have separate WIP PRs open so everybody can see the work being done. |
Collaborator
Author
|
Sorry for asking that, but I think this PR is based on |
Member
|
#17 has diverged very far from |
Member
|
sorry, I mistyped. I meant #18. |
Member
|
but if the the new PR is compatible with |
Still need an SVD or a S2 symmetrization though
Should double check if it'd be the same first nn and then ll
for larger sum(ll), this error accumulates so a larger tolerance should be set...
no accumulated error in this version; necessary documentation added
so that we don't have "almost none zero" zeros singular values, neither the large equivariance violation.
The efficiency is not yet satisfactory though
zhanglw0521
force-pushed
the
Recursion_evaluation
branch
from
a1fa4e2 to
3556260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the new RPE implementation has been merged, I'd like to make another PR about the recursive evaluation of the Coupling Coefficients which is based on the new RPE implementation. More specifically, this PR aims to provide the implementation of calculating the RPE basis for given$n,l \in \mathbb{N}^N$ via
for an arbitrary partition$n = (n_1,n_2)$ and $l = (l_1,l_2)$ .
Some conflicts will occur and should be resolved, the benchmark tests should be removed before it is ready to merge. I'll try to create a task list for this PR.