-
Notifications
You must be signed in to change notification settings - Fork 362
[DRAFT] AddingMagneticMACE
#1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Hey @CheukHinHoJerry thank you very much for that. Yes the model should be in the extensions.py, the new blocks themselves can be in blocks.py. For the random rotations, could please create a new file in data folder called augmentations.py where you put it? thank you |
|
No problem - I will make those changes and let you know. Thank you for the quick comment. |
|
@ilyes319 I turned on precommit checks but there are too many lines in |
MagneticMACE MagneticMACE
|
@CheukHinHoJerry Yep you can disable that for that file! |
This PR implements
MagneticMACEas abstract class with other spin-informed variant of magnetic MACE. Major changes areThis PR is still WIP because I am not sure how one would like to place the code and I am current at the stage of adding some tests , happy to make changes.
Questions in my mind for @ilyes319 atm:
extension.pytoo? Or should they be placed where they are supposed to be outsideextension.py?