Fix some problems with preprocessed datasets #761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a problem when using preprocessed datasets in combination with multiheads.
When getting a structure from
HDF5Dataset, it is first loaded into aConfiguration. When initializing theConfiguration, the head is not specified and, therefore, is set to "Default" by default. Currently, the correct head saved to theHDF5Datasetis then only set, ifconfiguration.head is None, which currently is never the case.This pull request should fix that by always setting the head to the value saved in the
HDF5Datasetand toDefault, if it isn't specified (in line with howheadsare set when turning the configuration intoAtomicData).In principle, this assignment can also be moved into the initialization of the
Configuration.There is also - indepentent of multiheads - a problem with preprocessed test sets, if they are preprocessed with multiple processes. They were, contrary to what the documentation says and
run_train.pyexpects, not saved in their own directory, but instead in the same directory with different file names.