Closed
Conversation
sstone
force-pushed
the
simple-taproot-channels-v2
branch
5 times, most recently
from
a83fb4c to
c00154f
Compare
sstone
force-pushed
the
simple-taproot-channels-v2
branch
3 times, most recently
from
caac917 to
3374a21
Compare
sstone
force-pushed
the
simple-taproot-channels-v2
branch
3 times, most recently
from
a7348f8 to
ba4c11c
Compare
sstone
force-pushed
the
simple-taproot-channels-v2
branch
2 times, most recently
from
7e949ea to
dd34985
Compare
sstone
force-pushed
the
simple-taproot-channels-v2
branch
3 times, most recently
from
29845c4 to
d7ab72a
Compare
sstone
force-pushed
the
simple-taproot-channels-v2
branch
2 times, most recently
from
c043174 to
118b5bc
Compare
We add a new specific commitment format for taproot channels, and high-level methods for creating and spending taproot channel transactions.
sstone
force-pushed
the
simple-taproot-channels-v2
branch
from
118b5bc to
9712599
Compare
This commit implements: - feature bits for simple taproot channels - TLV extensions for funding/closing wire messages - modifications to how we handle channel funding, splicing and mutual closing - changes to the commitment structures The v1 channel establishment protocol is modified to include nonces for creating and signing taproot transactions. This is bascially the original simple taproot proposal, which does not cover dual-funding, splices and rbf. We assume that simple taproot channels depends on the simple close protocol, which we extend to include musig2 nonces. Dual-funding, splices and rbf are supported by extending the interactive tx session protocol to include musig2 nonce, which are attached to the `tx_complete` message. There are 2 types of nonces: - "funding nonces", which are used to sign a new funding tx that spends the current funding tx (splice, rbf). - "commit nonces", which are used to sign the commit tx that is one of the outputs of the interactive session. "funding nonces" can be randomly generated on-the-fly: either the interactive session will fail, and they can be forgotten, or it will succeed and we'll get a new, fully signed funding tx. "commit nonces" can be deterministically generated. This make nonce exchange simpler to reason about: - when we send `tx_complete`, we know exactly what the funding tx and commit tx will be (so the funding tx id can be mixed in the nonce generation process). - dual funding, splice and rbf message do not need to be modified Channel re-establishment becomes a bit more complex, as one node could still be waiting for signatures while the other has completed the splice workflow, but it can be mitigated by storing the last sent commit_sig and re-sending it again if needed.
sstone
force-pushed
the
simple-taproot-channels-v2
branch
from
9712599 to
4df5e97
Compare
Member
Author
|
replaced by #3103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simpler alternative to #2868: musig2 nonce exchange has been moved into the interactive tx session, and become much simpler as there
open_v2/accept_v2,splice_ orrbfmessages remain unchanged. Channel re-establishment logic becomes a bit more complex, which is mitigated by storing and re-sending the lastcommit_sig` message if needed.