Merged
Conversation
thomash-acinq
force-pushed
the
peer-storage-spec
branch
5 times, most recently
from
b3c4282 to
c8fb76b
Compare
thomash-acinq
force-pushed
the
peer-storage-spec
branch
from
c8fb76b to
ad27653
Compare
Closed
thomash-acinq
force-pushed
the
peer-storage-spec
branch
3 times, most recently
from
049b236 to
f67a738
Compare
Replaces the custom channel data backup with the new peer storage (lightning/bolts#1110)
thomash-acinq
force-pushed
the
peer-storage-spec
branch
from
f67a738 to
e62306e
Compare
t-bast
reviewed
Apr 3, 2025
modules/core/src/commonMain/kotlin/fr/acinq/lightning/wire/LightningMessages.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/wire/LightningMessages.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/wire/LightningMessages.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/wire/ChannelTlv.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonTest/kotlin/fr/acinq/lightning/channel/states/NegotiatingTestsCommon.kt
Show resolved
Hide resolved
modules/core/src/commonTest/kotlin/fr/acinq/lightning/wire/LightningCodecsTestsCommon.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonTest/kotlin/fr/acinq/lightning/io/peer/PeerTest.kt
Show resolved
Hide resolved
.../commonTest/kotlin/fr/acinq/lightning/serialization/channel/StateSerializationTestsCommon.kt
Outdated
Show resolved
Hide resolved
t-bast
reviewed
Apr 7, 2025
modules/core/src/commonMain/kotlin/fr/acinq/lightning/io/Peer.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/io/Peer.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/io/Peer.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/serialization/channel/Encryption.kt
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/serialization/channel/Encryption.kt
Outdated
Show resolved
Hide resolved
...e/src/commonTest/kotlin/fr/acinq/lightning/channel/states/WaitForFundingSignedTestsCommon.kt
Show resolved
Hide resolved
modules/core/src/commonTest/kotlin/fr/acinq/lightning/wire/LightningCodecsTestsCommon.kt
Show resolved
Hide resolved
| "right": "03c57839fd412868a398bea05d01678a752661126a2d1357a0f7cb6f0c60311125" | ||
| }, | ||
| "remotePerCommitmentSecrets": "<redacted>", | ||
| "remoteChannelData": { |
Member
There was a problem hiding this comment.
I cannot put a comment on deleted files, but can you explain why you removed some test cases from this nonreg folder? We should always be able to keep decoding the .bin file, otherwise we may be introducing a compatibility issue. Instead of deleting a whole folder, you should always just update the json file, which shows that we can still decode the binary state (even though we're now ignoring the remoteChannelData).
Contributor
Author
There was a problem hiding this comment.
The test cases that I removed are using ShutdownTlv.ChannelData which I thought we wanted to remove. I've restored the tests and kept the legacy TLV.
Member
There was a problem hiding this comment.
Got it, that was the reason, because we're including a whole Shutdown message in those states. Let's keep it for now, and this will be cleaned up when we get rid of v2 and v3 in #685
.../commonTest/kotlin/fr/acinq/lightning/serialization/channel/StateSerializationTestsCommon.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonTest/kotlin/fr/acinq/lightning/wire/LightningCodecsTestsCommon.kt
Outdated
Show resolved
Hide resolved
This reverts commit c94350e.
but keep the ones for channelreestablish and shutdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the custom channel data backup with the new peer storage (lightning/bolts#1110)