Remove spurious interactive-tx commit_sig retransmission#737
Merged
Conversation
t-bast
force-pushed
the
dont-send-spurious-commit-sig
branch
from
59a7972 to
808d281
Compare
t-bast
force-pushed
the
dont-send-spurious-commit-sig
branch
from
808d281 to
0b7e86c
Compare
We fully implement lightning/bolts#1214 to stop retransmitting `commit_sig` when our peer has already received it. We also correctly set `next_commitment_number` to let our peer know whether we have received their `commit_sig` or not.
t-bast
force-pushed
the
dont-send-spurious-commit-sig
branch
from
0b7e86c to
1c3be14
Compare
remyers
suggested changes
Apr 10, 2025
modules/core/src/commonMain/kotlin/fr/acinq/lightning/channel/states/Syncing.kt
Show resolved
Hide resolved
remyers
suggested changes
Apr 10, 2025
Contributor
remyers
left a comment
remyers
left a comment
There was a problem hiding this comment.
Looks good, but I have a question about sending tx_abort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fully implement lightning/bolts#1214 to stop retransmitting
commit_sigwhen our peer has already received it. We also correctly setnext_commitment_numberto let our peer know whether we have received theircommit_sigor not.Should only be merged once ACINQ/eclair#2966 has been deployed to the ACINQ node, which will likely happen this week.