Conversation
t-bast
force-pushed
the
refactor-channel-keys
branch
2 times, most recently
from
e68b0c7 to
4f56b1f
Compare
t-bast
force-pushed
the
refactor-channel-keys
branch
from
4f56b1f to
bc67872
Compare
t-bast
force-pushed
the
refactor-channel-keys
branch
from
bc67872 to
f53b382
Compare
pm47
previously approved these changes
Oct 1, 2025
Member
pm47
left a comment
pm47
left a comment
There was a problem hiding this comment.
Tested end-to-end against eclair.
We refactor our `ChannelKeys` to use the same model as `eclair`. This is a first step before refactoring transactions and channel data similarly to what was done in `eclair` in preparation for taproot channels. Backwards-compatibility is guaranteed by our unit tests for the local key manager and transactions building.
t-bast
force-pushed
the
refactor-channel-keys
branch
from
f53b382 to
3b8d4eb
Compare
Member
Author
|
Rebased with a trivial minor conflict in |
pm47
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We refactor our
ChannelKeysto use the same model aseclair. This is a first step before refactoring transactions and channel data similarly to what was done ineclairin preparation for taproot channels.Backwards-compatibility is guaranteed by our unit tests for the local key manager and transactions building. We also have e2e tests with
eclairwith the complete taproot feature which validate these changes.