Conversation
- Added a function to check if the application is running via pipx. - Updated the update command logic to handle pipx installations appropriately. - Improved user feedback during the update process.
- Removed push event triggers from build-docker workflow. - Updated release handling to trigger Docker build on new releases. - Simplified image tagging logic for better clarity and efficiency.
There was a problem hiding this comment.
Pull Request Overview
This PR adds pipx installation support to Printerm and streamlines CI/CD workflows. The main purpose is to enable automatic detection of pipx installations and use the appropriate update mechanism (pipx vs pip) accordingly.
Key changes:
- Added pipx detection logic to both CLI and GUI interfaces for smart update mechanism selection
- Simplified Docker build workflow to trigger only on releases instead of main branch pushes
- Removed redundant Docker build step from release workflow
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| printerm/interfaces/gui/widgets/main_window.py | Added pipx detection function and conditional update logic in GUI update dialog |
| printerm/interfaces/cli.py | Added pipx detection function and conditional update logic in CLI update command |
| .github/workflows/release.yaml | Removed Docker build job to simplify release workflow |
| .github/workflows/build-docker.yml | Simplified triggers to only build on releases and workflow dispatch |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Consolidated the is_running_via_pipx function into the utils.py file for better organization and reusability across the application. - Removed duplicate function definitions from cli.py and main_window.py.
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipx Support and Workflow Streamlining
📝 Description
This pull request enhances Printerm to support pipx installations and streamlines the CI/CD workflows for improved efficiency and maintainability.
🔧 Changes
Core Functionality
pipx updatewhen running via pipx, falling back to pip otherwiseCI/CD Improvements
🧪 Testing
📋 Checklist