Write the correct formula for the Watterson estimator of theta in the doc#645
Open
Gullumluvl wants to merge 1 commit intoANGSD:masterfrom
Open
Write the correct formula for the Watterson estimator of theta in the doc#645Gullumluvl wants to merge 1 commit intoANGSD:masterfrom
Gullumluvl wants to merge 1 commit intoANGSD:masterfrom
Conversation
… doc. Now corresponds to what the code actually does (in saf2theta), and to what the literature says it should be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Angsd authors,
I believe the formula for the Watterson estimator of theta should be fixed in the doc.
I got confused when reading it, and also by the formula written in Korneliussen et al. 2013.
The actual computation is doing the right thing though, here is the bit that matters:
angsd/misc/realSFS.cpp
Line 866 in 68b0838
so my modification is just about the documentation.
Best,