-
-
Notifications
You must be signed in to change notification settings - Fork 419
feat(frontend): add character counter and text validation to prevent OOM crashes #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AmazingDude
wants to merge
3
commits into
AOSSIE-Org:main
Choose a base branch
from
AmazingDude:feat/character-limit-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
9cfad3d
feat: add character counter and text validation to prevent backend OO…
AmazingDude a12e2c6
fix: resolve infinite loading state on empty text submission
AmazingDude cc07e52
fix: align character counter and button logic to use trimmed text length
AmazingDude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
23 changes: 23 additions & 0 deletions
23
eduaid_web/src/components/FormValidation/CharacterCounter.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import React from 'react'; | ||
|
|
||
| const CharacterCounter = ({ text, maxLength = 2500 }) => { | ||
| const count = text?.length || 0; | ||
| const isNearLimit = count > maxLength * 0.8; | ||
| const isOverLimit = count > maxLength; | ||
|
|
||
| let textColor = "text-[#E4E4E4]"; | ||
| if (isOverLimit) { | ||
| textColor = "text-red-500 font-bold"; | ||
| } else if (isNearLimit) { | ||
| textColor = "text-yellow-500"; | ||
| } | ||
|
|
||
| return ( | ||
| <div className={`text-xs text-right mt-1 transition-colors duration-300 ${textColor}`}> | ||
| {count} / {maxLength} characters | ||
| {isOverLimit && <span className="ml-2">Exceeds model capacity</span>} | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default CharacterCounter; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| export const validateTextInput = (text) => { | ||
| if (!text || text.trim().length === 0) { | ||
| return { isValid: false, error: "Please enter some text to generate questions." }; | ||
| } | ||
|
|
||
| if (text.length < 50) { | ||
| return { isValid: false, error: "Text is too short. Please provide at least 50 characters." }; | ||
| } | ||
|
|
||
| if (text.length > 2500) { | ||
| return { isValid: false, error: "Text exceeds the 2500 character limit. Please shorten your text." }; | ||
| } | ||
|
|
||
| return { isValid: true, error: "" }; | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.