Feat(ui): add pre-generation quiz review and confirmation flow#518
Open
piyush06singhal wants to merge 8 commits intoAOSSIE-Org:mainfrom
Open
Feat(ui): add pre-generation quiz review and confirmation flow#518piyush06singhal wants to merge 8 commits intoAOSSIE-Org:mainfrom
piyush06singhal wants to merge 8 commits intoAOSSIE-Org:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a Review & Confirm step: Text_Input persists configuration (including inputSource) to localStorage and navigates to a new Review page, which hydrates the config, displays a summary, and on confirm POSTs to the backend to generate qaPairs and then navigates to the output page. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant TextInput as Text_Input
participant LocalStorage as localStorage
participant Review as Review
participant Backend as Backend\ API
participant Output as Output\ Page
User->>TextInput: Fill config & click Next
TextInput->>LocalStorage: Save text, difficulty, numQuestions, useWikipedia, inputSource
TextInput->>Review: Navigate to /review
Review->>LocalStorage: Load configuration on mount
Review->>Review: Derive inputSource & validate fields
Review->>User: Display review summary
User->>Review: Click Confirm & Generate
Review->>Backend: POST {input_text, max_questions, use_mediawiki}
Backend-->>Review: Return qaPairs
Review->>LocalStorage: Store qaPairs & update last5Quizzes
Review->>Output: Navigate to /output
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
piyush06singhal
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
eduaid_web/src/pages/Text_Input.jsx (1)
61-80:⚠️ Potential issue | 🟠 MajorGoogle Doc path currently requires two clicks to reach review.
When
docUrlis present, the first click only fetches content (Lines 62–73) and does not persist configuration or navigate; users must click Next again.💡 Proposed fix
const handleSaveToLocalStorage = async () => { + const persistAndNavigate = (finalText) => { + localStorage.setItem("textContent", finalText); + localStorage.setItem("difficulty", difficulty); + localStorage.setItem("numQuestions", numQuestions); + localStorage.setItem("useWikipedia", isToggleOn.toString()); + localStorage.setItem("inputSource", docUrl ? "Google Doc URL" : "Text"); + navigate("/review"); + }; + if (docUrl) { setLoading(true); try { const data = await apiClient.post("/get_content", { document_url: docUrl }); - setDocUrl(""); - setText(data || "Error in retrieving"); + const finalText = data || "Error in retrieving"; + setDocUrl(""); + setText(finalText); + persistAndNavigate(finalText); } catch (error) { console.error("Error:", error); setText("Error retrieving Google Doc content"); } finally { setLoading(false); } } else if (text) { - localStorage.setItem("textContent", text); - localStorage.setItem("difficulty", difficulty); - localStorage.setItem("numQuestions", numQuestions); - localStorage.setItem("useWikipedia", isToggleOn.toString()); - navigate("/review"); + persistAndNavigate(text); } };🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@eduaid_web/src/pages/Text_Input.jsx` around lines 61 - 80, The handleSaveToLocalStorage flow for Google Docs only fetches content and doesn't persist settings or navigate, requiring a second click; inside the async branch where docUrl is truthy (in function handleSaveToLocalStorage), after successfully receiving data and setting setText(...) (and before clearing setDocUrl("") if you prefer), also write the same localStorage keys used in the text branch (textContent, difficulty, numQuestions, useWikipedia) and then call navigate("/review") so the user is taken to the review page in one click; ensure this happens only on successful fetch (inside the try block) and keep the existing loading/error handling intact.
🧹 Nitpick comments (1)
eduaid_web/src/pages/Review.jsx (1)
89-94: Hardenlast5Quizzesparsing to avoid breaking post-success navigation.If
last5Quizzescontains malformed JSON,JSON.parsethrows and prevents redirect even after a successful generation response.💡 Proposed fix
- let last5Quizzes = JSON.parse(localStorage.getItem("last5Quizzes")) || []; + let last5Quizzes = []; + try { + const parsed = JSON.parse(localStorage.getItem("last5Quizzes")); + if (Array.isArray(parsed)) last5Quizzes = parsed; + } catch (_) { + last5Quizzes = []; + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@eduaid_web/src/pages/Review.jsx` around lines 89 - 94, Parsing localStorage.getItem("last5Quizzes") with JSON.parse can throw on malformed JSON and block post-success navigation; wrap the parse in a try/catch (or use a safe parse helper) to fall back to an empty array when parse fails, ensure the result is an array before pushing quizDetails (e.g., if not Array, set to []), then push quizDetails, trim to 5, and call localStorage.setItem as before; update the code around the last5Quizzes variable/logic so a bad stored value never prevents redirect.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@eduaid_web/src/pages/Review.jsx`:
- Around line 57-66: getEndpoint currently maps difficulty and questionType to a
string used as the route, but that string comes from localStorage-backed state
and may be malformed; before calling apiClient.post with the computed endpoint
(where apiClient.post is invoked elsewhere in this file), validate the computed
endpoint against an allowlist of permitted endpoints (e.g., "get_shortq",
"get_mcq", "get_shortq_hard", "get_mcq_hard") and refuse or fallback if it is
not in the list. Update the code paths that call apiClient.post to run this
check (use the getEndpoint(resultingDifficulty, questionType) return value) and
handle invalid endpoints by logging an error and returning early or using a safe
default endpoint.
- Line 22: The code in Review.jsx sets numQuestions with
parseInt(localStorage.getItem("numQuestions")) || 10 which treats a saved "0" as
falsy and overwrites it; change the logic to default only when the stored value
is missing by using a null-coalescing approach (e.g., check if
localStorage.getItem("numQuestions") is null and only then use 10, or use
parseInt(localStorage.getItem("numQuestions") ?? "10", 10)) and ensure parseInt
is called with radix 10 so that a saved "0" is preserved.
- Around line 26-31: The current heuristic in Review.jsx using the local
variable inputSource and inspecting text (lines with text.includes(...)) is
brittle; change the component to read an explicit persisted inputSource field
(e.g., review.inputSource or props.inputSource) and use that value to set
inputSource, falling back to the existing text-based heuristic only if the
explicit field is undefined. Update any code paths that construct the review
object to persist inputSource on submit/upload so Review.jsx can reliably read
it, and remove or demote the brittle detection logic (keep it as a fallback in
the inputSource assignment).
---
Outside diff comments:
In `@eduaid_web/src/pages/Text_Input.jsx`:
- Around line 61-80: The handleSaveToLocalStorage flow for Google Docs only
fetches content and doesn't persist settings or navigate, requiring a second
click; inside the async branch where docUrl is truthy (in function
handleSaveToLocalStorage), after successfully receiving data and setting
setText(...) (and before clearing setDocUrl("") if you prefer), also write the
same localStorage keys used in the text branch (textContent, difficulty,
numQuestions, useWikipedia) and then call navigate("/review") so the user is
taken to the review page in one click; ensure this happens only on successful
fetch (inside the try block) and keep the existing loading/error handling
intact.
---
Nitpick comments:
In `@eduaid_web/src/pages/Review.jsx`:
- Around line 89-94: Parsing localStorage.getItem("last5Quizzes") with
JSON.parse can throw on malformed JSON and block post-success navigation; wrap
the parse in a try/catch (or use a safe parse helper) to fall back to an empty
array when parse fails, ensure the result is an array before pushing quizDetails
(e.g., if not Array, set to []), then push quizDetails, trim to 5, and call
localStorage.setItem as before; update the code around the last5Quizzes
variable/logic so a bad stored value never prevents redirect.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.gitignoreeduaid_web/src/App.jseduaid_web/src/pages/Review.jsxeduaid_web/src/pages/Text_Input.jsx
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
eduaid_web/src/pages/Review.jsx (1)
100-107: Avoid duplicating full quiz payload in history storage.Line 100 stores full
responseDatainqaPairs, and Line 106 stores it again per history entry. This can exhaust localStorage quota faster and make history writes brittle.💡 Proposed refactor
const quizDetails = { difficulty: reviewData.difficulty, numQuestions: reviewData.numQuestions, date: new Date().toLocaleDateString(), - qaPair: responseData, + qaPairCount: Array.isArray(responseData) ? responseData.length : undefined, };Also applies to: 122-127
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@eduaid_web/src/pages/Review.jsx` around lines 100 - 107, The code currently writes the full responseData twice — once into localStorage "qaPairs" and again embedded into each quizDetails history entry (qaPair field), which duplicates data and risks filling localStorage; change quizDetails to store a lightweight reference instead (e.g., an id, timestamp, or index) rather than the entire responseData, keep the full responseData only under the single "qaPairs" key, and update any retrieval logic that reads quizDetails.qaPair to resolve the reference back to the full QA payload from the "qaPairs" store; look for usages of localStorage.setItem("qaPairs"), the quizDetails object (qaPair, date, difficulty, numQuestions), and any history write paths around lines handling quizDetails (including the other block at 122-127) to implement this reference-based approach.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@eduaid_web/src/pages/Review.jsx`:
- Around line 82-97: The code currently builds requestData from reviewData
without validating inputs; before constructing requestData in the function where
setLoading(true) and getEndpoint(...) are used, add guards that trim
reviewData.text and ensure it's non-empty, and validate reviewData.numQuestions
is a positive integer (e.g., Number.isInteger(...) && >0); if either check
fails, call setLoading(false), surface an appropriate error (console.error or
set a UI error state) and return early; keep existing useWikipedia conversion
for use_mediawiki and reuse symbols endpoint, allowedEndpoints, requestData,
setLoading to locate and implement the checks.
In `@eduaid_web/src/pages/Text_Input.jsx`:
- Around line 50-56: The current handlers setText(data.content || data.error)
and setText("Error uploading file") allow transport/error messages to become the
quiz content and later be persisted via textContent; change these handlers in
the upload/fetch logic (the upload handler and the fetch response handling in
Text_Input.jsx) to not place error strings into the text state—use an empty
string or keep previous valid state and set a separate error flag/state (e.g.,
uploadError) instead, still call setInputSource("file") as needed, and ensure
the code that writes/persists textContent checks that text is non-empty and not
an error before saving.
- Around line 69-73: Trim the user-provided inputs before performing truthy
checks to avoid whitespace-only values triggering backend calls or navigation;
specifically, trim docUrl before the if check that calls setLoading and
apiClient.post("/get_content", { document_url: docUrl }) (use a trimmedDocUrl
variable) and likewise trim the text/value used in the save/review flow (the
variable checked around lines 91-97) and use the trimmed versions for
routing/POST decisions so only non-empty, non-whitespace strings proceed.
- Around line 96-97: When the textarea is edited, ensure the inputSource state
and persisted value are updated to "text" so summaries reflect manual edits: in
the textarea's onChange handler (the function handling user text edits around
the current textarea block) call setInputSource("text") and
localStorage.setItem("inputSource","text") before any save/submit logic, so the
existing localStorage.setItem("inputSource", inputSource) / navigate("/review")
flow picks up the updated source.
---
Nitpick comments:
In `@eduaid_web/src/pages/Review.jsx`:
- Around line 100-107: The code currently writes the full responseData twice —
once into localStorage "qaPairs" and again embedded into each quizDetails
history entry (qaPair field), which duplicates data and risks filling
localStorage; change quizDetails to store a lightweight reference instead (e.g.,
an id, timestamp, or index) rather than the entire responseData, keep the full
responseData only under the single "qaPairs" key, and update any retrieval logic
that reads quizDetails.qaPair to resolve the reference back to the full QA
payload from the "qaPairs" store; look for usages of
localStorage.setItem("qaPairs"), the quizDetails object (qaPair, date,
difficulty, numQuestions), and any history write paths around lines handling
quizDetails (including the other block at 122-127) to implement this
reference-based approach.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
eduaid_web/src/pages/Text_Input.jsx (1)
49-51:⚠️ Potential issue | 🟠 MajorDo not write upload error text into
textstate.Line 50 still allows non-content error payloads to become quiz content (
data.content || data.error). This can propagate invalid content into review/generation.💡 Proposed fix
- const data = await apiClient.postFormData("/upload", formData); - setText(data.content || data.error); - setInputSource("file"); + const data = await apiClient.postFormData("/upload", formData); + const uploadedText = + typeof data?.content === "string" ? data.content.trim() : ""; + if (!uploadedText) { + console.error("Uploaded file content is empty or invalid"); + return; + } + setText(uploadedText); + setInputSource("file");🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@eduaid_web/src/pages/Text_Input.jsx` around lines 49 - 51, The code is assigning error payloads into the quiz text by doing setText(data.content || data.error); change this so setText is only called when data.content exists (e.g., if (data.content) setText(data.content)); handle error cases separately (e.g., setError state, show a toast, or console.error with data.error) and only call setInputSource("file") on successful content upload; update the upload handling around apiClient.postFormData, setText, and setInputSource to reflect this separation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@eduaid_web/src/pages/Review.jsx`:
- Around line 22-24: The hydration of numQuestions from localStorage can produce
NaN or non-positive values; update the logic around
savedNumQuestions/numQuestions to parse the stored value and validate it is a
positive integer (e.g., use parseInt then Number.isInteger and > 0) and
otherwise fall back to 10; ensure this validation is performed where
numQuestions is defined so downstream code (including the generation logic that
expects a positive count) always receives a valid positive integer.
In `@eduaid_web/src/pages/Text_Input.jsx`:
- Around line 66-70: In handleSaveToLocalStorage, add a guard that validates
numQuestions is a positive integer (>0) before persisting and navigating to
'/review' — if numQuestions is invalid, do not write to localStorage or call
navigate and instead surface an error (e.g., set an error state or return
early). Apply the same validation for the other save/submit path around lines
96-103 (the alternative save handler) so both code paths check the numQuestions
variable prior to storing docUrl/text/numQuestions and calling
navigate('/review').
---
Duplicate comments:
In `@eduaid_web/src/pages/Text_Input.jsx`:
- Around line 49-51: The code is assigning error payloads into the quiz text by
doing setText(data.content || data.error); change this so setText is only called
when data.content exists (e.g., if (data.content) setText(data.content)); handle
error cases separately (e.g., setError state, show a toast, or console.error
with data.error) and only call setInputSource("file") on successful content
upload; update the upload handling around apiClient.postFormData, setText, and
setInputSource to reflect this separation.
… review navigation
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
eduaid_web/src/pages/Text_Input.jsx (1)
49-51:⚠️ Potential issue | 🟠 MajorDo not persist backend error text as quiz content.
data.content || data.errorcan still write error strings intotext, and that can flow into review/generation as valid content.💡 Proposed fix
- const data = await apiClient.postFormData("/upload", formData); - setText(data.content || data.error); - setInputSource("file"); + const data = await apiClient.postFormData("/upload", formData); + if (typeof data?.content === "string" && data.content.trim()) { + setText(data.content.trim()); + setInputSource("file"); + } else { + console.error("Invalid uploaded file content"); + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@eduaid_web/src/pages/Text_Input.jsx` around lines 49 - 51, The code is writing backend error text into the quiz content by using setText(data.content || data.error); change the flow so only a valid payload populates text: call setText(...) and setInputSource("file") only when apiClient.postFormData returns a genuine content (e.g., data.content is non-empty/valid); otherwise do not call setText with data.error — instead surface the error via an error state/notification (e.g., setUploadError or showToast) and keep input source unchanged. Target the post-upload logic around apiClient.postFormData, setText, and setInputSource to implement this check.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@eduaid_web/src/pages/Text_Input.jsx`:
- Around line 31-33: When hydrating numQuestions from localStorage (the
savedNumQuestions -> setNumQuestions path in Text_Input.jsx), validate the
parsed value before calling setNumQuestions: parse with
parseInt(savedNumQuestions, 10), ensure the result is a finite integer and
within your allowed range (e.g., >= 1), and fall back to the existing default
(or omit state update) if validation fails; update the branch that currently
calls setNumQuestions(parseInt(savedNumQuestions, 10)) to perform this check and
only set state when the value is valid.
---
Duplicate comments:
In `@eduaid_web/src/pages/Text_Input.jsx`:
- Around line 49-51: The code is writing backend error text into the quiz
content by using setText(data.content || data.error); change the flow so only a
valid payload populates text: call setText(...) and setInputSource("file") only
when apiClient.postFormData returns a genuine content (e.g., data.content is
non-empty/valid); otherwise do not call setText with data.error — instead
surface the error via an error state/notification (e.g., setUploadError or
showToast) and keep input source unchanged. Target the post-upload logic around
apiClient.postFormData, setText, and setInputSource to implement this check.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@eduaid_web/src/pages/Text_Input.jsx`:
- Around line 89-93: The fetch failure and invalid `/get_content` responses are
only logged to console; update the Text_Input.jsx logic to surface these errors
to the UI by introducing and using a state setter (e.g., add error state like
setFetchError or setErrorMessage via useState) and call it wherever you
currently call console.error (the block checking if (!data || typeof data !==
"string" || !data.trim()) and the similar block at lines ~106-108), still call
setLoading(false) and return, and then render that error state in the component
(display a user-friendly message and optional retry) so users see actionable
feedback instead of only console messages.
- Line 40: The hydration for useWikipedia can set isToggleOn to NaN because
parseInt(savedWikipedia, 10) may return NaN for legacy/non-numeric values;
change the logic around savedWikipedia (from Text_Input.jsx) to parse and
validate before calling setIsToggleOn — e.g., compute const parsed =
parseInt(savedWikipedia, 10), check Number.isNaN(parsed) (or use a
numeric/default fallback like 0/1) and only call setIsToggleOn(parsed) with a
validated number (or convert to Boolean/0/1) so toggle updates remain stable;
update the usage sites that reference savedWikipedia, parseInt, and
setIsToggleOn accordingly.
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
eduaid_web/src/pages/Text_Input.jsx (1)
138-140:⚠️ Potential issue | 🟡 MinorPrevent decrementing below 1 to match save validation.
The decrement function allows
numQuestionsto reach 0, buthandleSaveToLocalStoragerequires a positive count. This inconsistency can confuse users when "Next" silently fails at 0.💡 Proposed fix
const decrementQuestions = () => { - setNumQuestions((prev) => (prev > 0 ? prev - 1 : 0)); + setNumQuestions((prev) => (prev > 1 ? prev - 1 : 1)); };🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@eduaid_web/src/pages/Text_Input.jsx` around lines 138 - 140, decrementQuestions currently allows numQuestions to go to 0 while handleSaveToLocalStorage expects a positive count; update decrementQuestions so it enforces a minimum of 1 (e.g., change the conditional in decrementQuestions that uses setNumQuestions to ensure prev > 1 before decrementing), and double-check any UI/state initialization around numQuestions and the handleSaveToLocalStorage validation to keep behavior consistent.
🧹 Nitpick comments (1)
eduaid_web/src/pages/Text_Input.jsx (1)
120-127: Handle the case when no input is provided.If both URL and text are empty/whitespace-only, clicking "Next" silently does nothing. Consider adding an else branch to inform the user.
💡 Proposed fix
} else if (trimmedText) { localStorage.setItem("textContent", trimmedText); localStorage.setItem("difficulty", difficulty); localStorage.setItem("numQuestions", numQuestions.toString()); localStorage.setItem("useWikipedia", isToggleOn.toString()); localStorage.setItem("inputSource", inputSource); navigate("/review"); + } else { + setError("Please enter text or provide a Google Doc URL."); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@eduaid_web/src/pages/Text_Input.jsx` around lines 120 - 127, The current Next-button flow saves inputs and calls navigate("/review") only when trimmedText (or URL) exists, but if both are empty the click silently does nothing; add an else branch after the existing if/else-if that handles the case when neither inputSource URL nor trimmedText has content and surface a user-visible error (e.g., set a component state like errorMessage or call an existing showToast/alert) so the user is informed and prevented from proceeding; update the Text_Input.jsx handler that uses trimmedText, inputSource, and navigate to perform this validation and display.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@eduaid_web/src/pages/Text_Input.jsx`:
- Around line 88-91: The handler that checks validQuestionCount (where
numQuestions and validQuestionCount are validated in Text_Input.jsx) currently
just console.error and returns, so the user gets no feedback; update the
validation branch in that function to set a visible UI error instead of only
logging — e.g., set a state like questionCountError or validationError (create
useState if missing) and populate it with a user-friendly message when
validQuestionCount is false, ensure the JSX near the numQuestions input renders
that state (styled and accessible) and prevents advancing until cleared; keep
the console.error for devs but add the user-facing error message and clear it on
successful validation or on input change.
- Around line 64-72: The file upload branch currently only logs failures to
console; update the invalid-response branch and the catch block in the file
upload handler to call the component error state setter (setError) with a
user-facing message (e.g., "File upload failed" or the caught error message) and
clear or reset input-related state as appropriate; specifically, replace or
augment the console.error in the invalid data branch and the catch block that
surround setText and setInputSource so they call setError(...) and optionally
setInputSource(null) or setText("") to ensure the UI shows the error like the
URL fetch flow does.
---
Outside diff comments:
In `@eduaid_web/src/pages/Text_Input.jsx`:
- Around line 138-140: decrementQuestions currently allows numQuestions to go to
0 while handleSaveToLocalStorage expects a positive count; update
decrementQuestions so it enforces a minimum of 1 (e.g., change the conditional
in decrementQuestions that uses setNumQuestions to ensure prev > 1 before
decrementing), and double-check any UI/state initialization around numQuestions
and the handleSaveToLocalStorage validation to keep behavior consistent.
---
Nitpick comments:
In `@eduaid_web/src/pages/Text_Input.jsx`:
- Around line 120-127: The current Next-button flow saves inputs and calls
navigate("/review") only when trimmedText (or URL) exists, but if both are empty
the click silently does nothing; add an else branch after the existing
if/else-if that handles the case when neither inputSource URL nor trimmedText
has content and surface a user-visible error (e.g., set a component state like
errorMessage or call an existing showToast/alert) so the user is informed and
prevented from proceeding; update the Text_Input.jsx handler that uses
trimmedText, inputSource, and navigate to perform this validation and display.
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed Issues:
Fixes #515
Summary
This PR introduces a Review & Confirmation step before triggering quiz generation.
Users can now verify all configuration settings before the API call is made, improving UX clarity and preventing accidental submissions.
What’s Added
Flow Change
Before:
Home → Question Type → Input → [API Call] → Output
After:
Home → Question Type → Input → Review → [API Call] → Output
↓
Back to Edit
Key Improvements
Files Changed
No backend changes.
No new dependencies added.
Screenshots/Recordings
Review Page – Desktop View
Testing Performed
Additional Notes
Checklist
AI Usage Disclosure
I have used the following AI models and tools:
We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact.
Summary by CodeRabbit
New Features
Chores