-
-
Notifications
You must be signed in to change notification settings - Fork 353
Update Twitter logo to X across the website #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -3,7 +3,7 @@ import Link from 'next/link' | |||||||||||
| import { Container } from '@/components/Container' | ||||||||||||
| import { FontAwesomeIcon } from '@fortawesome/react-fontawesome' | ||||||||||||
| import { faEnvelope } from '@fortawesome/free-solid-svg-icons' | ||||||||||||
| import { faDiscord, faGithub, faGitlab, faTwitter } from '@fortawesome/free-brands-svg-icons' | ||||||||||||
| import { faDiscord, faGithub, faGitlab, faXTwitter } from '@fortawesome/free-brands-svg-icons' | ||||||||||||
|
|
||||||||||||
| function NavLink({ href, children }) { | ||||||||||||
| return ( | ||||||||||||
|
|
@@ -46,7 +46,7 @@ export function Footer() { | |||||||||||
| <FontAwesomeIcon icon={faDiscord} size='xl' /> | ||||||||||||
| </Link> | ||||||||||||
| <Link aria-label="Follow on Twitter" className=' text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://twitter.com/aossie_org'> | ||||||||||||
| <FontAwesomeIcon icon={faTwitter} size='xl' /> | ||||||||||||
| <FontAwesomeIcon icon={faXTwitter} size="xl" /> | ||||||||||||
|
Comment on lines
48
to
+49
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update the aria-label to match X branding. Screen readers will still announce “Twitter”. Consider “Follow on X” (or “Follow on X (Twitter)”). 🔧 Suggested fix- <Link aria-label="Follow on Twitter" className=' text-zinc-400 hover:text-[`#00843D`] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://twitter.com/aossie_org'>
+ <Link aria-label="Follow on X" className=' text-zinc-400 hover:text-[`#00843D`] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://twitter.com/aossie_org'>
<FontAwesomeIcon icon={faXTwitter} size="xl" />
</Link>📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||
| </Link> | ||||||||||||
| </div> | ||||||||||||
| </div> | ||||||||||||
|
|
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
@fortawesome/free-brands-svg-icons faXTwitter version history when added💡 Result:
faXTwitter(the “X / Twitter” brand icon) was added to Font Awesome /@fortawesome/free-brands-svg-iconsin v6.4.2. Evidence: the Font Awesome repo tracked the “X (New Twitter branding)” request under milestone 6.4.2 [1], and the@fortawesome/free-brands-svg-icons@6.4.2package containsfaXTwittertypings (faXTwitter.d.ts) [2]. Stack Overflow users also note it works starting in 6.4.2 (and not in 6.4.0) [3].So, you need:
@fortawesome/free-brands-svg-icons >= 6.4.2.Sources: [1] FortAwesome/Font-Awesome#19827, [2] https://app.unpkg.com/%40fortawesome/free-brands-svg-icons%406.4.2/files/faXTwitter.d.ts, [3] https://stackoverflow.com/questions/77140202/twitter-x-using-font-awesome-6-not-working
Upgrade
@fortawesome/free-brands-svg-iconsto v6.4.2 or later.The
faXTwittericon was added in v6.4.2. The current pinned version 6.2.1 does not export this icon, causing the build to fail. Upgrade the package dependency to resolve.🤖 Prompt for AI Agents