Add new feeds, remove misspelled or unused filters#19
Open
JdeGeit wants to merge 3 commits intoAbuseIO:masterfrom
Open
Add new feeds, remove misspelled or unused filters#19JdeGeit wants to merge 3 commits intoAbuseIO:masterfrom
JdeGeit wants to merge 3 commits intoAbuseIO:masterfrom
Conversation
cleaned out some filters that are no longer/not used in shadowserver reports
Member
|
due to the historic nature of testing samples removing old filters might break systems that want to restore from source files. Can you provide errors / examples where the errors occures when invalid? Cause it is better to fix that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the addition of a number of new feeds as well as the removal of filters no longer used by Shadowserver in its reports. This should also prevent exceptions from occurring when the parser is looking for things in the csv that do not exist (as these non existent things have been removed from the feeds).
No new classifications for the new feeds have been added as an update to classifications (without new feeds) is still pending before these new ones can also be added.
AbuseIO/AbuseIO#409
I think there will be breakage should the parser be updated before the classifications have been added.
Version tag should be updated