Layout improvements to Graph Editor#2775
Open
jstone-lucasfilm wants to merge 6 commits intoAcademySoftwareFoundation:mainfrom
Open
Layout improvements to Graph Editor#2775jstone-lucasfilm wants to merge 6 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm wants to merge 6 commits intoAcademySoftwareFoundation:mainfrom
Conversation
This changelist improves the Layout engine in the Graph Editor, organizing its logic into a new Layout class, and aligning its approach with the Sugiyama layered graph drawing algorithm (https://en.wikipedia.org/wiki/Layered_graph_drawing). Additionally, layout is now performed over two frames, allowing the true rendered dimensions of each node to be used in final node placement. Two specific issues addressed by this changelist are AcademySoftwareFoundation#1414 and AcademySoftwareFoundation#2432.
Member
Author
|
In order to provide some visual intuition for the new layout behavior, here are a few typical examples: Marble Example Nodegraph: Standard Surface Nodegraph (close-up of coat computation): OpenPBR Nodegraph (close-up of coat computation): |
- Add UI toggles for individual algorithm phases, allowing developers to understand their impact on the layout. - Use the term "virtual" instead of "dummy", for better alignment with the original Sugiyama approach. - Simplify structures and method interfaces for clarity. - Apply const correctness improvements to loops.
- Move method comments from Layout.cpp to Layout.h, providing a better developer overview of the class. - Add a sortByBarycenter method for clarity. - Make better use of range-based-for loops in the code.
This changelist removes legacy variables and methods that are no longer referenced by the new layout engine.
This changelist reorders the methods of the Layout class by their place in the layout algorithm, making the flow of the code clearer to a new developer.
lfl-eholthouser
approved these changes
Feb 21, 2026
Contributor
lfl-eholthouser
left a comment
lfl-eholthouser
left a comment
There was a problem hiding this comment.
This looks great and it's a really exciting change. Thanks @jstone-lucasfilm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist improves the Layout engine in the Graph Editor, organizing its logic into a new Layout class, and aligning its approach with the Sugiyama layered graph drawing algorithm (https://en.wikipedia.org/wiki/Layered_graph_drawing).
Additionally, layout is now performed over two frames, allowing the true rendered dimensions of each node to be used in final node placement.
Two specific issues addressed by this changelist are #1414 and #2432.