Fix direct lighting in MslProgram::bindLighting#2781
Merged
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom Feb 19, 2026
Merged
Conversation
This changelist fixes a uniform name mismatch in `MslProgram::bindLighting`, which was causing the direct lighting term to be missing on MacOS, as reported in AcademySoftwareFoundation#2769. In the MSL rendering path, uniforms are stored with a `GlobalContext` struct prefix, and the `hasUniform` and `bindUniform` methods correctly resolve these prefixed names through the global uniform name map.
jstone-lucasfilm
merged commit 71ae1fc
into
AcademySoftwareFoundation:main
33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist fixes a uniform name mismatch in
MslProgram::bindLighting, which was causing the direct lighting term to be missing on MacOS, as reported in #2769.In the MSL rendering path, uniforms are stored with a
GlobalContextstruct prefix, and thehasUniformandbindUniformmethods correctly resolve these prefixed names through the global uniform name map.