Skip to content

Comments

Migrate Python packaging to pyproject.toml#2782

Open
jstone-lucasfilm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm:dev_python_builds
Open

Migrate Python packaging to pyproject.toml#2782
jstone-lucasfilm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm:dev_python_builds

Conversation

@jstone-lucasfilm
Copy link
Member

This changelist migrates the MaterialX Python packaging configuration from the legacy setup.py script to the modern pyproject.toml standard, as defined in PEP 517 and PEP 621.

This changelist migrates the MaterialX Python packaging configuration from the legacy `setup.py` script to the modern `pyproject.toml` standard, as defined in PEP 517 and PEP 621.
@jstone-lucasfilm
Copy link
Member Author

Once this latest improvement is reviewed and merged, I believe we can mark issue #2414 as resolved.

Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember exactly why this is still needed, but it looks good on the surface.

@jstone-lucasfilm
Copy link
Member Author

Thanks @JeanChristopheMorinPerso, this is mainly the completion of work that we started in #2525, fully moving over from setup.py to pyproject.toml.

My expectation is that the main benefit will be improved maintainability going forward, and that Python developers won't notice any change at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants