Improvements to interface name validation#2785
Open
jstone-lucasfilm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
Improvements to interface name validation#2785jstone-lucasfilm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
This changelist improves the validation of interface name attributes in `ValueElement::validate`, including the following specific changes: - Replace `getAncestorOfType<NodeGraph>` with `getAncestorOfType<GraphElement>`, allowing interface names to be validated within any graph scope, including the document scope. - When a value element is a direct child of a graph element, resolve its interface name against the parent graph rather than the containing graph, fixing validation of nodegraph inputs that reference document-level inputs. - When no declaration is found for a graph element, fall back to the graph element itself as the declaration scope. Collectively, these improvements address issue AcademySoftwareFoundation#1832.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist improves the validation of interface name attributes in
ValueElement::validate, including the following specific changes:getAncestorOfType<NodeGraph>withgetAncestorOfType<GraphElement>, allowing interface names to be validated within any graph scope, including the document scope.Collectively, these improvements address issue #1832.