Merged
Conversation
Member
dale-c-anderson
commented
Sep 11, 2025
dale-c-anderson
commented
- let curl follow redirects - if requesting /jdoe.keys, but the gitlab username is actually jDoe (with mixed case), gitlab will redirect the request to the correct case (add -L to curl)
- only ever return public keys (grep for ^ssh)
- make sure the command fails if the server responds with something other than 2xx (add --fail to curl)
* let curl follow redirects - if requesting /jdoe.keys, but the gitlab username is actually jDoe (with mixed case), gitlab will redirect the request to the correct case (add -L to curl) * only ever return public keys (grep for ^ssh) * make sure the command fails if the server responds with something other than 2xx (add --fail to curl)
dale-c-anderson
force-pushed
the
fix-key-setup-problems
branch
from
69ffe31 to
7d3705d
Compare
Chithrak07
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.