fix(commerce_pos): support inclusive tax#22
Closed
wilderuncat wants to merge 2 commits intoAcroMedia:7.x-2.xfrom
wilderuncat:2824865-tax_inclusive_fix
Closed
fix(commerce_pos): support inclusive tax#22wilderuncat wants to merge 2 commits intoAcroMedia:7.x-2.xfrom wilderuncat:2824865-tax_inclusive_fix
wilderuncat wants to merge 2 commits intoAcroMedia:7.x-2.xfrom
wilderuncat:2824865-tax_inclusive_fix
Conversation
added 2 commits
May 8, 2017 23:45
Adds a check to see if the tax is inclusive before recalculating it. This has a known issue where the Components section with the Subtotal no longer shows the tax breakdown. https://www.drupal.org/node/2824865
This makes it so that when we adjust the amount manually, we can still calculate the correct tax rates. https://www.drupal.org/node/2824865
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check to see if the tax is inclusive before recalculating it.
This is a similar approach to how #14 does it, but it doesn't break when not using Tax Inclusive prices.
Like the other approach, this has a known issue where the Components section with the Subtotal no longer shows the tax breakdown.
https://www.drupal.org/node/2824865