-
Notifications
You must be signed in to change notification settings - Fork 116
Adding section about error handling for empty categoryPath #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds documentation for error handling behavior in the Live Search productSearch query when sorting by category position with an empty or invalid categoryPath. The new section explains how the Search Service gracefully handles such requests by falling back to relevance-based sorting and returning a structured GraphQL warning instead of throwing a FAILED_PRECONDITION error.
Key changes:
- Documents the fallback behavior when position sorting is attempted with invalid categoryPath
- Provides the structure of the warning message returned in the errors array
- Includes an example query that triggers this warning scenario
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Looks good to me. 👍 |
Co-authored-by: Kevin Harper <keharper@users.noreply.github.com> Co-authored-by: Margaret Eker <meker@adobe.com>
Pull request overview
This pull request adds documentation for error handling behavior in the Live Search
productSearchquery when sorting by category position with an empty or invalidcategoryPath. The new section explains how the Search Service gracefully handles such requests by falling back to relevance-based sorting and returning a structured GraphQL warning instead of throwing aFAILED_PRECONDITIONerror.Key changes:
Affected pages