Skip to content

This is my first Pull Request #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TheMetabaron wants to merge 3 commits into
base: master
Choose a base branch
from
Open

This is my first Pull Request #5

TheMetabaron wants to merge 3 commits into from

Conversation

@TheMetabaron
Copy link

@TheMetabaron TheMetabaron commented Jul 27, 2017

No description provided.

@DavidWhitlock
Copy link
Member

DavidWhitlock commented Jul 27, 2017

It looks like your changes will break the unit tests. Here's what Travis said:

Running edu.pdx.cs410J.katas.MinesweeperTest
Tests run: 8, Failures: 0, Errors: 1, Skipped: 2, Time elapsed: 0.009 sec <<< FAILURE! - in edu.pdx.cs410J.katas.MinesweeperTest
oneSquareWithMine(edu.pdx.cs410J.katas.MinesweeperTest)  Time elapsed: 0 sec  <<< ERROR!
edu.pdx.cs410J.katas.RaggedBoardException
	at edu.pdx.cs410J.katas.MinesweeperTest.oneSquareWithMine(MinesweeperTest.java:46)

@TheMetabaron
Copy link
Author

TheMetabaron commented Jul 27, 2017

We fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheMetabaron @DavidWhitlock