Allow Negative Size/Duration walls for Beatmap V3#21
Open
Provini wants to merge 1 commit intoAeroluna:masterfrom
Open
Allow Negative Size/Duration walls for Beatmap V3#21Provini wants to merge 1 commit intoAeroluna:masterfrom
Provini wants to merge 1 commit intoAeroluna:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CustomJSONData currently has this fixed, but only for V2 Beatmaps. V3 Beatmaps are, however, still affected in v1.39.1
This patch should allow V3 beatmaps that has negative size/duration walls to properly load. I ensured I incorporated this patch similarly to how you did for V2 beatmaps, to ensure it doesn't break mapping extensions.
Feel free to double check my work to make sure I applied this properly, but it seems to work fine for "Superluminal" which utilized negative duration, as a v3 beatmap.
Edit: Fixed formatting and positioning of the patch, as well as commented out the original ObstacleConverter patch.