Skip to content

Conversation

@t-barnard
Copy link

@t-barnard t-barnard commented Nov 13, 2025

Description

Most of the changes in this section involve updating function declarations to call parameters by reference instead of value. This greatly speeds up the program, because it is making less copies of large data objects. Specifically, the "grid" object is used in a lot of functions and was taking a lot of time when passed by value.

Addresses # (issue)
These changes increase program speed at runtime.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

How Has This Been Tested?

These changes have been tested on multiple computers and do not seem to affect the program aside from increasing the speed.

Test configuration

  • Operating system: [e.g., Hal]
  • Compiler, version number: [e.g., Python 3.X, gcc version X.X]
  • Any details about your local setup that are relevant

@abukowski21
Copy link
Collaborator

Looks good to me! Checked outputs and indeed they do not change.

I'm going to assign this to Aaron R & he can give a final blessing

@abukowski21 abukowski21 marked this pull request as ready for review November 18, 2025 14:45
Copy link
Contributor

@aaronjridley aaronjridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem fine to me.

@aaronjridley aaronjridley merged commit c6fa64f into AetherModel:develop Nov 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants