[temp] Frontend feat/new testsets integration #3323
Closed
+39,933
−8,329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…InfiniteVirtualTable component - Add optional created_by_id field to testset interface for tracking testset creators - Replace custom Table implementation with InfiniteVirtualTableFeatureShell - Migrate to useTableManager and useTableActions hooks for state management - Replace manual column definitions with createStandardColumns utility - Add TestsetsHeaderFilters component for search and filtering - Consolidate action handlers
…elete/export buttons - Replace deleteButton ReactNode with TableDeleteConfig object - Replace renderExportButton callback with TableExportConfig object - Remove settingsDropdownDelete in favor of unified deleteAction config - Move button rendering responsibility to InfiniteVirtualTableFeatureShell - Remove direct Button, Tooltip, and Trash icon imports from useTableManager - Update shellProps to pass deleteAction and exportAction instea
…etching and custom rendering - Add ExpandableRowConfig and ExpandIconRenderProps types for expandable row configuration - Create useExpandableRows hook to manage expand state, async child fetching, and caching - Add expandable prop to InfiniteVirtualTableInner and InfiniteVirtualTableFeatureShell - Support custom expand icons with loading states (default to circle icons) - Add accordion mode to collapse other rows when one exp
…ant and revision query endpoints - Add testset_refs, testset_variant_refs, and testset_revision_refs parameters to query endpoints - Pass reference filters through to underlying artifact service queries - Add include_archived and windowing parameters to testset revision query endpoint - Make testset_revision_query parameter optional with default None value - Forward all filtering and pagination parameters to artifact service layer
…s support - Add expandable rows to testsets table showing variants and revisions as nested children - Implement async fetching of variants and revisions on row expansion with loading states - Add custom expand icons (plus/minus circles) integrated into Name column instead of separate column - Display variants with GitBranch icon and revisions with version tags (similar to app variant revisions) - Add indentation levels for visual
…wer synchronization - Create testcase.ts module for managing testcase_id query parameter state - Add testcaseIdAtom to track testcase ID from URL - Implement syncTestcaseStateFromUrl to sync URL param with atom state - Add route validation to only allow testcase param on /testsets routes - Create clearTestcaseQueryParam and clearTestcaseParamAtom for cleanup - Export testcase atoms and actions from state/url/index.ts and state
…es page to InfiniteVirtualTable with editable drawer - Add windowing field to TestcasesResponse model for pagination support - Implement compute_next_windowing in testcases router for cursor-based pagination - Update BlobsDAO to use id attribute (UUID7) instead of created_at for windowing - Create TestcasesTable component with InfiniteVirtualTable integration - Add testcase edit drawer with deep linking support via testcase_id URL
…t testset modals - Replace Typography.Paragraph with TableDescription component for page description - Uncomment DeleteTestsetModal and CreateTestsetModal components to restore modal functionality
…description - Replace Typography.Paragraph with TableDescription component for consistent styling - Import TableDescription from InfiniteVirtualTable components
- Add tailwind class to remove left padding from ant-dropdown-trigger elements - Ensures consistent spacing within the editor wrapper
…lay and validation - Extend SimpleChatMessage interface to support tool_calls, tool_call_id, name, function_call, and provider-specific fields - Make content optional (nullable) to support assistant messages with tool_calls but no content - Add ToolCall interface for structured function calling - Implement extractDisplayTextFromMessage to show formatted tool calls for assistant messages - Add ToolMessageHeader component to display
…ge objects in TestcaseEditDrawerContent - Update isChatMessage validation to accept tool_calls array and function_call as valid content - Make content nullable in parseMessageObject to support assistant messages with tool_calls but no content - Preserve tool calling fields (name, tool_call_id, tool_calls, function_call) when parsing messages - Preserve provider-specific fields (provider_specific_fields, annotations, refusal) when parsing messages - Make
… from testsets - Delete fetchTestsetVariants module and TestsetExpandedContent component - Create fetchTestsetRevisions module to fetch revisions directly by testset_id - Remove testset_variant_id field from TestsetRevision interface - Update testsets page to expand testsets directly to revisions (2-level hierarchy) - Remove variant transformation logic and simplify expand handler - Update revision row transformation to use testset name
…detection and collapsed display - Extend SyntaxHighlightPlugin to detect base64 strings in code tokens and create Base64Nodes for them - Update token matching logic to handle base64 nodes alongside highlight nodes - Add base64 type comparison in token match check to prevent unnecessary re-renders - Import base64 utilities ($createBase64Node, $isBase64Node, isBase64String, parseBase64String) - Update getDiffRange utility to support
…unified-table-layout-testsets-and-testcases
- Implement `useSmartResizableColumns` hook to intelligently distribute table column widths based on container size and column constraints - Add support for flexible columns that share remaining space proportionally while respecting maxWidth constraints - Reduce default minimum column width from 80px to 48px for better space utilization - Add `maxWidth` property to actions column definition for better width control - Fix selection column width handling
…t-testsets-and-testcases
…_ids - Replace testset_ids array with testset_refs object array in fetchTestsetMetadata and fetchTestset API calls - Add p-6 padding to TestcasesTable container for consistent layout spacing
…nuItems from rowHeight config to TextTable - Add menuItems field to rowHeight config in TestcasesTableShellProps - Import MenuProps type from antd - Pass rowHeight.menuItems to TextTable as settingsDropdownMenuItems prop (undefined when controls are hidden)
…genta-AI/agenta into frontend-feat/new-testsets-integration
… creating new testset revisions - Add ImportTestsetRevisionModal component with CSV/JSON file upload via drag-and-drop interface - Add file validation for CSV (comma-separated with headers) and JSON (array of objects) formats - Add file preview table showing first 10 rows of uploaded data before import - Add uploadTestsetRevisionPreview API function to upload files to existing testsets as new revisions - Add Import button to Test
…ub.com/Agenta-AI/agenta into frontend-feat/new-testsets-integration
…genta-AI/agenta into frontend-feat/new-testsets-integration
…tions column from export
- Remove useAtomValue import and testsetMetadataAtom usage
- Remove exportOptions configuration with resolveValue, resolveColumnLabel, and filename
- Set exportEnabled: false on actions column to exclude it from export
- Replace exportOptions prop with enableExport={false} in TextTable component
…ub.com/Agenta-AI/agenta into frontend-feat/new-testsets-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.