Merged
Conversation
…l setters Replace SetBBOCallback/SetErrorCallback/SetConnectionCallback with a single Callbacks struct passed at construction. Add OrderBook and PublicTrade data types for future subscription support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add SubscribeTrades/UnsubscribeTrades for real-time trade events - Add HandleTradeEvent to parse and deliver PublicTrade data via callback - Change BBO bid/ask fields to std::optional since ticker updates may omit them - Remove lastPrice from BBO (not reliably present in ticker events) - Remove subscribed_markets_ tracking (unused) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubscribeTrades/UnsubscribeTradesmethods for real-time trade event streamingHandleTradeEventto parse incoming trade messages intoPublicTradestructsstd::optional<double>since ticker updates may omit themlastPricefromBBO(not reliably present in ticker events)subscribed_markets_set and its mutexmain.cppTest plan
🤖 Generated with Claude Code