Resources by AlekSi · Pull Request #9 · AlekSi/alice

AlekSi · 2019-08-04T10:41:38Z

Closes #4.

golangcibot · 2019-08-04T10:42:44Z

resources/client.go

+	"net/http"
+)
+
+type Client struct {


exported type Client should have comment or be unexported (from golint)

golangcibot · 2019-08-04T10:42:44Z

resources/client.go

+	return http.DefaultClient
+}
+
+type StatusResponse struct {


exported type StatusResponse should have comment or be unexported (from golint)

golangcibot · 2019-08-04T10:42:44Z

resources/client.go

+	Used  int
+}
+
+func (c *Client) Status() (*StatusResponse, error) {


exported method Client.Status should have comment or be unexported (from golint)

golangcibot · 2019-08-04T10:42:44Z

resources/client.go

+	if err != nil {
+		return nil, err
+	}
+	defer resp.Body.Close()


Error return value of resp.Body.Close is not checked (from errcheck)

golangcibot · 2019-08-25T11:12:48Z

resources/client.go

+	"github.com/AlekSi/alice"
+)
+
+type Quota struct {


exported type Quota should have comment or be unexported (from golint)

golangcibot · 2019-08-25T11:12:48Z

resources/client.go

+	Used  int
+}
+
+type Sound struct {


exported type Sound should have comment or be unexported (from golint)

golangcibot · 2019-08-25T11:12:48Z

resources/client.go

+	return &res, nil
+}
+
+func (c *Client) UploadSound(name string, r io.Reader) (*Sound, error) {


exported method Client.UploadSound should have comment or be unexported (from golint)

golangcibot · 2019-08-25T11:12:48Z

resources/client.go

+	return &res.Sound, nil
+}
+
+func (c *Client) UploadSoundFile(filename string) (*Sound, error) {


exported method Client.UploadSoundFile should have comment or be unexported (from golint)

golangcibot · 2019-08-25T11:12:48Z

resources/client.go

+	return c.UploadSound(filepath.Base(filename), f)
+}
+
+func (c *Client) ListSounds() ([]Sound, error) {


exported method Client.ListSounds should have comment or be unexported (from golint)

golangcibot · 2019-08-25T11:12:49Z

resources/client.go

+}
+
+func (c *Client) UploadSoundFile(filename string) (*Sound, error) {
+	f, err := os.Open(filename)


G304: Potential file inclusion via variable (from gosec)

Refs #4.

golangcibot · 2019-11-09T13:50:47Z

resources/client.go

+	StrictDecoder bool         // disallow unexpected fields in responses
+}
+
+func (c *Client) do(req *http.Request, respBody interface{}) error {


cognitive complexity 32 of func (*Client).do is high (> 30) (from gocognit)

golangcibot · 2019-11-09T13:50:47Z

resources/client.go

+	}
+
+	var jsonRequst bool
+	if c.OAuthToken != "" {


if statements should only be cuddled with assignments used in the if statement itself (from wsl)

golangcibot · 2019-11-09T13:50:47Z

resources/client.go

+	}
+	if req.Body != nil && req.Header.Get("Content-Type") == "" {
+		jsonRequst = true
+		req.Header.Set("Content-Type", "application/json; charset=utf-8")


only cuddled expressions if assigning variable or using from line above (from wsl)

golangcibot · 2019-11-09T13:50:47Z

resources/client.go

+	if c.OAuthToken != "" {
+		req.Header.Set("Authorization", "OAuth "+c.OAuthToken)
+	}
+	if req.Body != nil && req.Header.Get("Content-Type") == "" {


if statements should only be cuddled with assignments (from wsl)

golangcibot · 2019-11-09T13:50:48Z

resources/client.go

+			if err = json.Indent(&body, b, "", "  "); err != nil {
+				return err
+			}
+			req.Body = ioutil.NopCloser(&body)


assignments should only be cuddled with other assignments (from wsl)

golangcibot · 2019-11-09T13:50:51Z

resources/client.go

+	if _, err = io.Copy(fw, r); err != nil {
+		return nil, err
+	}
+	if err = mw.Close(); err != nil {


if statements should only be cuddled with assignments (from wsl)

golangcibot · 2019-11-09T13:50:51Z

resources/client.go

+	if err != nil {
+		return nil, err
+	}
+	req.Header.Add("Content-Type", mw.FormDataContentType())


expressions should not be cuddled with blocks (from wsl)

golangcibot · 2019-11-09T13:50:51Z

resources/client.go

+	if err = c.do(req, &res); err != nil {
+		return nil, err
+	}
+	return &res.Sound, nil


return statements should not be cuddled if block has more than two lines (from wsl)

golangcibot · 2019-11-09T13:50:52Z

resources/client_test.go

+
+	skillID := os.Getenv("ALICE_TEST_SKILL_ID")
+	oAuthToken := os.Getenv("ALICE_TEST_OAUTH_TOKEN")
+	if skillID == "" || oAuthToken == "" {


only one cuddle assignment allowed before if statement (from wsl)

golangcibot · 2019-11-09T13:50:52Z

resources/client.go

@@ -0,0 +1,204 @@
+package resources


ST1000: at least one file in a package should have a package comment (from stylecheck)

# Conflicts: # .gitignore

codecov · 2019-12-08T11:07:30Z

Codecov Report

Merging #9 into master will decrease coverage by 13.02%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
- Coverage   32.44%   19.42%   -13.03%     
===========================================
  Files           4        5        +1     
  Lines         188      314      +126     
===========================================
  Hits           61       61               
- Misses        120      246      +126     
  Partials        7        7

Impacted Files	Coverage Δ
resources/client.go	`0% <0%> (ø)`
handler.go	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9837c9b...80a26c2. Read the comment docs.

AlekSi self-assigned this Aug 4, 2019

AlekSi mentioned this pull request Aug 4, 2019

Add helpers for working with images #4

Open

golangcibot reviewed Aug 4, 2019

View reviewed changes

golangcibot reviewed Aug 25, 2019

View reviewed changes

AlekSi added 6 commits November 9, 2019 16:49

Add Status method for images client.

fa0cfe1

Refs #4.

Run tests for all packages.

d627194

Move client to resources package.

dba24dc

Expand README.

144cb98

Expand example.

275761c

WIP

cfa7e79

AlekSi force-pushed the resources branch from 0829cc9 to cfa7e79 Compare November 9, 2019 13:49

golangcibot reviewed Nov 9, 2019

View reviewed changes

AlekSi added 2 commits December 8, 2019 14:01

Delete old workflows.

acf749c

Merge branch 'master' into resources

80a26c2

# Conflicts: # .gitignore

Base automatically changed from master to main January 16, 2021 07:37

Conversation

AlekSi commented Aug 4, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Dec 8, 2019 •

edited

Loading